-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Enable fips supported algorithms #66589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Enable fips supported algorithms
[3006.x] Enable fips supported algorithms
May 23, 2024
dwoz
changed the title
[3006.x] Enable fips supported algorithms
[wip] Enable fips supported algorithms
May 23, 2024
dwoz
changed the title
[wip] Enable fips supported algorithms
[wip] [3006.x] Enable fips supported algorithms
May 23, 2024
Provide helpful log messages on the master and minions if a minion uses signing or encryption that is not suppoted by the master.
dwoz
changed the title
[wip] [3006.x] Enable fips supported algorithms
[3006.x] Enable fips supported algorithms
Jun 5, 2024
twangboy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevent the use of non-fips approved algorithms when fips is enabled.
salt/crypt.py
to cryptography which validates the use of FIPS algorithmsWhat issues does this PR fix or reference?
Fixes: #66579
Previous Behavior
Crypto libraries PyCrypto, PyCryptodome, and M2Crypto would not properly enforce FIPS complaint algorithms are used. There was no way to use FIPS compliant aglorithms.
New Behavior
Python cryptography properly enforces only FIPS compliant libraries are used when the FIPS provder is enabled. Salt masters and minions are able to be configured to use FIPS compliant libraries.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.