[3006.x] Detect existing VC Build Tools on GitHub runners #66618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
twangboy
force-pushed
the
fix_build_tools
branch
from
96785c9
to
ec8ff22
Compare
dwoz
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the ability for the
install_vs_buildtools.ps1script to detect existing installations ofmsbuild.exeon any version of Visual Studio build tools if installed. This greatly shortens the build process as it takes 5 to 10 minutes to install VS build tools. The github runners come with Visual Studio build tools 2022, which seems to build all the Salt dependencies just fine.What issues does this PR fix or reference?
Fixes issue found during nightly build failure
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes