Fix for issue #8053: raise error on duplicate ID's in one state file #8589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now including the state file in which the RenderError occured. This makes it easier to track down e.g. YAML syntax errors.
- YAML exceptions are now re-reaised as SaltRenderErrors - Duplicate ID's in single state files now result in errors, and not just warnings. This is now consistent with the how conflicting ID's in separate state files are handled.
terminalmage
pushed a commit
that referenced
this pull request
Nov 17, 2013
Fix for issue #8053: raise error on duplicate ID's in one state file
|
Nice! |
|
@basepi this should be cherry picked |
|
Emilisto. My current SaltStack Program is doing exactly what yo uare doing. Is there a way to work around this? My program needs to touch/append to a file multiple times in a single run (each loop, the source appends its ID in a text file). How to handle? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the following state:
will now result in this error:
As a bonus, YAML compilation errors are now displayed with the environment and state included — making troubleshooting easier.