-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not resizing on dynamically received data #2
Comments
@seleckis I published |
please update readme so that we'll know how to use that :) |
@saltycrane, this only seems to work if the element is not of a fixed size, am I wrong? The issue we're seeing is that when text is added or removed programmatically, the text doesn't resize. Is there a way to work around this at present? Thank you for sharing your great work! |
Ah sorry guys, I didn't read the original issue carefully. The change I made in |
Beautiful! Thank you @saltycrane! |
Update: I just published |
@saltycrane is there any benefit to using the new version compared with the key-based workaround? Does it just implement the same behind the scenes? |
hi @slapbox, I'd say the main benefit is that it should work automatically without needing to add the React key. There actually is a difference in the implementation-- I'm using |
If the content of container is being changed dynamically then the hook does not recalculate the font size
The text was updated successfully, but these errors were encountered: