Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of app directory for Next.js 13 #314

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

cellis
Copy link
Contributor

@cellis cellis commented Jan 20, 2023

  • Next.js 13 reserves the app directory
  • Nextron uses the app directory.

With this change, nextron users can set appSrcDir in nextron.config.js and then update the 'app' string in their background.ts file.

I wasn't sure how to thread the nextron config into background.ts, but I added comments in the templates for new project creators.

Should close #311

@saltyshiomix saltyshiomix self-requested a review January 22, 2023 04:10
@saltyshiomix saltyshiomix added the enhancement New feature or request label Jan 22, 2023
Copy link
Owner

@saltyshiomix saltyshiomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR and it works perfectly 👍

I proudly merge this PR, but I'll rewrite this config soon bacause app directory is one of the experimental features for Next.js v13.

Anyway, I'm so glad to have your PR!

@saltyshiomix saltyshiomix merged commit bc1dd60 into saltyshiomix:main Jan 22, 2023
@saltyshiomix
Copy link
Owner

saltyshiomix commented Jan 22, 2023

Sorry I made a mistake, Next.js v13 does not support app dir configuration with next export for now.
So I'll rollback this until Next.js will support it.

saltyshiomix added a commit that referenced this pull request Jan 22, 2023
saltyshiomix added a commit that referenced this pull request Jan 22, 2023
This reverts commit f33a914.
@edwardna1
Copy link

Next added support for next export as shown here https://beta.nextjs.org/docs/app-directory-roadmap#planned-features
so I think this would be good to merge

@andirsun
Copy link
Collaborator

andirsun commented May 4, 2023

@edwardna1 you are right! We are going to keep an eye on it to add the support, please read here #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next 13 app dir
4 participants