Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): fix Chip types #1155

Merged
merged 7 commits into from Apr 8, 2024
Merged

feat(plasma-new-hope): fix Chip types #1155

merged 7 commits into from Apr 8, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Mar 29, 2024 •
edited by Yakutoc

Chip

  • поправлена типизация
  • компонент добавлен в поставку для sdds-serv, включая документацию

What/why changed

В Chip были неправильно указаны типы для view и size. Они должны определятся движком.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/caldera-online@0.31.0-canary.1155.8596953518.0
npm install @salutejs/plasma-asdk@0.68.0-canary.1155.8596953518.0
npm install @salutejs/plasma-b2c@1.310.0-canary.1155.8596953518.0
npm install @salutejs/plasma-new-hope@0.71.0-canary.1155.8596953518.0
npm install @salutejs/plasma-web@1.310.0-canary.1155.8596953518.0
npm install @salutejs/sdds-serv@0.35.0-canary.1155.8596953518.0
# or 
yarn add @salutejs/caldera-online@0.31.0-canary.1155.8596953518.0
yarn add @salutejs/plasma-asdk@0.68.0-canary.1155.8596953518.0
yarn add @salutejs/plasma-b2c@1.310.0-canary.1155.8596953518.0
yarn add @salutejs/plasma-new-hope@0.71.0-canary.1155.8596953518.0
yarn add @salutejs/plasma-web@1.310.0-canary.1155.8596953518.0
yarn add @salutejs/sdds-serv@0.35.0-canary.1155.8596953518.0

@TitanKuzmich TitanKuzmich self-assigned this Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1155/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 29, 2024 •
edited

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1155/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1155/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1155/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1155/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1155/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1155/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1155/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

⚡ Component performance testing

Result: 🟢 OK

neretin-trike
neretin-trike reviewed Apr 5, 2024
View reviewed changes
packages/plasma-b2c/src/components/Chip/Chip.config.tsx
${chipTokens.colorReadOnly}: var(--plasma-colors-inverse);
${chipTokens.backgroundReadOnlyHover}: var(--plasma-colors-primary);
${chipTokens.colorReadOnlyHover}: var(--plasma-colors-inverse);
`,
primary: css`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай пометим по всех конфигах это свойство @deprecated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Apr 8, 2024
Merged via the queue into dev with commit 33db5b5 Apr 8, 2024
28 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2699/fix-badge-types branch April 8, 2024 08:55
@Salute-Eva Salute-Eva mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TitanKuzmich @Yeti-or @neretin-trike