New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plasma-ui): hidden unnecessary pseudo-placeholder #271
Conversation
Demo canvas app deployed! |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-271/ |
Demo canvas app deployed! |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-271/ |
6ccc485
to
0c00858
Compare
Demo canvas app deployed! |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-271/ |
0c00858
to
e5cae1f
Compare
Demo canvas app deployed! |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-271/ |
Решение для проблемы #246
Из-за того что теперь нет наложения цветов placeholder + псевдо placeholder поменялись скриншоты тестов.
Примечание:
проблема воспроизводиться в мобильном приложение.
При чем в андроид студии - нет, только на физическом устройстве, оба раза на телефонах Samsung.
🐤 Download canary assets:
colors--canary.271.3746772746.xml
color_metro_ios-swift--canary.271.3746772746.swift
color_metro_kotlin--canary.271.3746772746.kt
color_metro_react-native--canary.271.3746772746.ts
color_sbermarket_ios-swift--canary.271.3746772746.swift
color_sbermarket_kotlin--canary.271.3746772746.kt
color_sbermarket_react-native--canary.271.3746772746.ts
color_sberprime_ios-swift--canary.271.3746772746.swift
color_sberprime_kotlin--canary.271.3746772746.kt
color_sberprime_react-native--canary.271.3746772746.ts
color_selgros_ios-swift--canary.271.3746772746.swift
color_selgros_kotlin--canary.271.3746772746.kt
color_selgros_react-native--canary.271.3746772746.ts
color_smbusiness_ios-swift--canary.271.3746772746.swift
color_smbusiness_kotlin--canary.271.3746772746.kt
color_smbusiness_react-native--canary.271.3746772746.ts
PlasmaTokensColor--canary.271.3746772746.swift
typo_mage_kotlin--canary.271.3746772746.kt
typo_mage_react-native--canary.271.3746772746.ts
typo_plasma_kotlin--canary.271.3746772746.kt
typo_plasma_react-native--canary.271.3746772746.ts
typo_ruler_kotlin--canary.271.3746772746.kt
typo_ruler_react-native--canary.271.3746772746.ts
typo_sage_kotlin--canary.271.3746772746.kt
typo_sage_react-native--canary.271.3746772746.ts
typo_sbermarket_kotlin--canary.271.3746772746.kt
typo_sbermarket_react-native--canary.271.3746772746.ts
typo_soulmate_kotlin--canary.271.3746772746.kt
typo_soulmate_react-native--canary.271.3746772746.ts
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @salutejs/plasma-temple@1.118.1-canary.271.3746772746.0 npm install @salutejs/plasma-ui@1.151.1-canary.271.3746772746.0 # or yarn add @salutejs/plasma-temple@1.118.1-canary.271.3746772746.0 yarn add @salutejs/plasma-ui@1.151.1-canary.271.3746772746.0