feat(plasma-core/ui): Pass onHide callback for hideToast handler #319

Yakutoc · 2023-02-08T07:29:19Z

Добавленна возможность прокинуть callback на hideToast.

Так же сделали overload метода showToast.

Так же возможность прокинуть onHide есть только в новой версии showToast.

Было: Аргументы передовались inline

Стало: Теперь как объект.

🐤 Download canary assets:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-b2c@1.138.0-canary.319.4163108583.0
npm install @salutejs/plasma-core@1.95.0-canary.319.4163108583.0
npm install @salutejs/plasma-icons@1.123.0-canary.319.4163108583.0
npm install @salutejs/plasma-temple@1.132.0-canary.319.4163108583.0
npm install @salutejs/plasma-ui@1.165.0-canary.319.4163108583.0
npm install @salutejs/plasma-web@1.164.0-canary.319.4163108583.0
npm install @salutejs/plasma-sb-utils@0.93.0-canary.319.4163108583.0
# or 
yarn add @salutejs/plasma-b2c@1.138.0-canary.319.4163108583.0
yarn add @salutejs/plasma-core@1.95.0-canary.319.4163108583.0
yarn add @salutejs/plasma-icons@1.123.0-canary.319.4163108583.0
yarn add @salutejs/plasma-temple@1.132.0-canary.319.4163108583.0
yarn add @salutejs/plasma-ui@1.165.0-canary.319.4163108583.0
yarn add @salutejs/plasma-web@1.164.0-canary.319.4163108583.0
yarn add @salutejs/plasma-sb-utils@0.93.0-canary.319.4163108583.0

packages/plasma-core/src/components/Toast/Toast.types.ts

packages/plasma-ui/src/components/Toast/Toast.stories.tsx

packages/plasma-core/src/components/Toast/ToastProvider.tsx

packages/plasma-core/src/components/Toast/Toast.types.ts

Salute-Eva · 2023-02-13T07:03:54Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-319/

Salute-Eva · 2023-02-13T07:15:21Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-319/
ui storybook: http://plasma.sberdevices.ru/pr/pr-319/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-319/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-319/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-319/temple-storybook/

packages/plasma-b2c/src/components/Toast/Toast.stories.tsx

packages/plasma-core/src/components/Toast/Toast.types.ts

packages/plasma-core/src/components/Toast/ToastProvider.tsx

website/plasma-ui-docs/docs/components/Toast.mdx

Salute-Eva · 2023-02-13T08:50:01Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-319/

Salute-Eva · 2023-02-13T08:56:47Z

Component performance testing

Result: 💀 Missing report, something went wrong

Check out current report in job artifacts!

Salute-Eva · 2023-02-13T09:03:33Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-319/

Salute-Eva · 2023-02-13T09:07:50Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-319/
ui storybook: http://plasma.sberdevices.ru/pr/pr-319/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-319/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-319/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-319/temple-storybook/

Salute-Eva · 2023-02-13T09:15:17Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-319/

Salute-Eva · 2023-02-13T09:22:45Z

Component performance testing

Result: 💀 Missing report, something went wrong

Check out current report in job artifacts!

Salute-Eva · 2023-02-13T09:24:57Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-319/

Salute-Eva · 2023-02-13T09:44:26Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-319/
ui storybook: http://plasma.sberdevices.ru/pr/pr-319/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-319/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-319/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-319/temple-storybook/

Salute-Eva · 2023-02-13T11:52:24Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-319/

Salute-Eva · 2023-02-13T11:59:50Z

Component performance testing

Result: 💀 Missing report, something went wrong

Check out current report in job artifacts!

Salute-Eva · 2023-02-13T12:02:29Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-319/

Salute-Eva · 2023-02-13T12:11:03Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-319/
ui storybook: http://plasma.sberdevices.ru/pr/pr-319/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-319/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-319/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-319/temple-storybook/

Yakutoc added enhancement New feature or request plasma-ui labels Feb 8, 2023

Yakutoc self-assigned this Feb 8, 2023

Yakutoc force-pushed the feat-toast-add-on-hide branch from a634f09 to 8a84cd1 Compare February 8, 2023 10:13

Yakutoc marked this pull request as ready for review February 8, 2023 11:03

Yakutoc requested review from Yeti-or and neretin-trike as code owners February 8, 2023 11:03

neretin-trike reviewed Feb 8, 2023

View reviewed changes

packages/plasma-core/src/components/Toast/Toast.types.ts Show resolved Hide resolved

Yakutoc force-pushed the feat-toast-add-on-hide branch from 8a84cd1 to 252e697 Compare February 9, 2023 08:56

neretin-trike reviewed Feb 9, 2023

View reviewed changes

packages/plasma-ui/src/components/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved

neretin-trike reviewed Feb 9, 2023

View reviewed changes

packages/plasma-core/src/components/Toast/ToastProvider.tsx Outdated Show resolved Hide resolved

neretin-trike reviewed Feb 9, 2023

View reviewed changes

packages/plasma-core/src/components/Toast/Toast.types.ts Show resolved Hide resolved

Yakutoc force-pushed the feat-toast-add-on-hide branch from 252e697 to 67824ca Compare February 10, 2023 05:25

Yakutoc requested a review from neretin-trike February 10, 2023 05:26

Yakutoc force-pushed the feat-toast-add-on-hide branch 2 times, most recently from a256f20 to 19554f2 Compare February 10, 2023 06:28

salute-developers deleted a comment from Salute-Eva Feb 10, 2023

Yeti-or reviewed Feb 13, 2023

View reviewed changes

packages/plasma-b2c/src/components/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved

packages/plasma-core/src/components/Toast/Toast.types.ts Show resolved Hide resolved

packages/plasma-core/src/components/Toast/Toast.types.ts Show resolved Hide resolved

Yeti-or reviewed Feb 13, 2023

View reviewed changes

Yakutoc force-pushed the feat-toast-add-on-hide branch from 18d9788 to cb656b9 Compare February 13, 2023 08:46

Yakutoc added 4 commits February 13, 2023 16:06

feat(plasma-core): add onHide/onShow callbacks

56a8594

feat(plasma-ui): add onHide action in storybook

36568f3

feat(plasma-b2c): add onHide action in storybook

4313b2d

feat(plasma-web): add onHide action in storybook

8cec2cf

Yakutoc added 2 commits February 13, 2023 16:09

docs(plasma-web): update toast

d7d26fe

docs(plasma-ui): update toast

3a04941

Yakutoc force-pushed the feat-toast-add-on-hide branch from cb656b9 to 3a04941 Compare February 13, 2023 09:12

chore(plasma-core): add issue for cypress "clearTimeout on hide" test

bec054b

Yakutoc requested a review from Yeti-or February 13, 2023 11:50

Yeti-or approved these changes Feb 13, 2023

View reviewed changes

neretin-trike approved these changes Feb 14, 2023

View reviewed changes

Yakutoc merged commit 8036600 into master Feb 14, 2023

Yakutoc deleted the feat-toast-add-on-hide branch February 14, 2023 06:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plasma-core/ui): Pass onHide callback for hideToast handler #319

feat(plasma-core/ui): Pass onHide callback for hideToast handler #319

Yakutoc commented Feb 8, 2023 •

edited by Salute-Eva

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

feat(plasma-core/ui): Pass onHide callback for hideToast handler #319

feat(plasma-core/ui): Pass onHide callback for hideToast handler #319

Conversation

Yakutoc commented Feb 8, 2023 • edited by Salute-Eva

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Salute-Eva commented Feb 13, 2023

Yakutoc commented Feb 8, 2023 •

edited by Salute-Eva