Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plasma-ui/web/b2c): Toast add offset prop #336

Merged
merged 10 commits into from Feb 15, 2023
Merged

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Feb 14, 2023

Добавлено новое свойство для перерасчета отступа блока подсказки - offset.

Считается в rem.

🐤 Download canary assets:

colors--canary.336.4183100754.xml
color_metro_ios-swift--canary.336.4183100754.swift
color_metro_kotlin--canary.336.4183100754.kt
color_metro_react-native--canary.336.4183100754.ts
color_sbermarket_ios-swift--canary.336.4183100754.swift
color_sbermarket_kotlin--canary.336.4183100754.kt
color_sbermarket_react-native--canary.336.4183100754.ts
color_sberprime_ios-swift--canary.336.4183100754.swift
color_sberprime_kotlin--canary.336.4183100754.kt
color_sberprime_react-native--canary.336.4183100754.ts
color_selgros_ios-swift--canary.336.4183100754.swift
color_selgros_kotlin--canary.336.4183100754.kt
color_selgros_react-native--canary.336.4183100754.ts
color_smbusiness_ios-swift--canary.336.4183100754.swift
color_smbusiness_kotlin--canary.336.4183100754.kt
color_smbusiness_react-native--canary.336.4183100754.ts
PlasmaTokensColor--canary.336.4183100754.swift
shadow_sbermarket_react-native--canary.336.4183100754.ts
typo_mage_ios-swift--canary.336.4183100754.swift
typo_mage_kotlin--canary.336.4183100754.kt
typo_mage_react-native--canary.336.4183100754.ts
typo_plasma_ios-swift--canary.336.4183100754.swift
typo_plasma_kotlin--canary.336.4183100754.kt
typo_plasma_react-native--canary.336.4183100754.ts
typo_ruler_ios-swift--canary.336.4183100754.swift
typo_ruler_kotlin--canary.336.4183100754.kt
typo_ruler_react-native--canary.336.4183100754.ts
typo_sage_ios-swift--canary.336.4183100754.swift
typo_sage_kotlin--canary.336.4183100754.kt
typo_sage_react-native--canary.336.4183100754.ts
typo_sbermarket_ios-swift--canary.336.4183100754.swift
typo_sbermarket_kotlin--canary.336.4183100754.kt
typo_sbermarket_react-native--canary.336.4183100754.ts
typo_soulmate_ios-swift--canary.336.4183100754.swift
typo_soulmate_kotlin--canary.336.4183100754.kt
typo_soulmate_react-native--canary.336.4183100754.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-b2c@1.141.0-canary.336.4183100754.0
npm install @salutejs/plasma-core@1.97.0-canary.336.4183100754.0
npm install @salutejs/plasma-icons@1.125.0-canary.336.4183100754.0
npm install @salutejs/plasma-temple@1.136.0-canary.336.4183100754.0
npm install @salutejs/plasma-ui@1.169.0-canary.336.4183100754.0
npm install @salutejs/plasma-web@1.167.0-canary.336.4183100754.0
npm install @salutejs/plasma-sb-utils@0.95.0-canary.336.4183100754.0
# or 
yarn add @salutejs/plasma-b2c@1.141.0-canary.336.4183100754.0
yarn add @salutejs/plasma-core@1.97.0-canary.336.4183100754.0
yarn add @salutejs/plasma-icons@1.125.0-canary.336.4183100754.0
yarn add @salutejs/plasma-temple@1.136.0-canary.336.4183100754.0
yarn add @salutejs/plasma-ui@1.169.0-canary.336.4183100754.0
yarn add @salutejs/plasma-web@1.167.0-canary.336.4183100754.0
yarn add @salutejs/plasma-sb-utils@0.95.0-canary.336.4183100754.0

@Yakutoc Yakutoc self-assigned this Feb 14, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-336/

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-336/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-336/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Yakutoc Yakutoc marked this pull request as ready for review February 14, 2023 08:49
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-336/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-336/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-336/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-336/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Yakutoc Yakutoc merged commit 6b7545f into master Feb 15, 2023
@Yakutoc Yakutoc deleted the feat-toast-add-offset branch February 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants