Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-core/ui/web/b2c): Slider move to core #360

Merged
merged 17 commits into from Mar 2, 2023
Merged

feat(plasma-core/ui/web/b2c): Slider move to core #360

merged 17 commits into from Mar 2, 2023

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Feb 20, 2023 •
edited by Salute-Eva

Так как большая часть логики Slider дублируется было принято решение вынести общую часть в plasma-core.

В plasma-web/b2c/ui/ сделан re-export с учетом визуальных отличий.

🐤 Download canary assets:

colors--canary.360.4312588821.xml
color_metro_ios-swift--canary.360.4312588821.swift
color_metro_kotlin--canary.360.4312588821.kt
color_metro_react-native--canary.360.4312588821.ts
color_sberHealth_ios-swift--canary.360.4312588821.swift
color_sberHealth_kotlin--canary.360.4312588821.kt
color_sberHealth_react-native--canary.360.4312588821.ts
color_sbermarket_ios-swift--canary.360.4312588821.swift
color_sbermarket_kotlin--canary.360.4312588821.kt
color_sbermarket_react-native--canary.360.4312588821.ts
color_sberprime_ios-swift--canary.360.4312588821.swift
color_sberprime_kotlin--canary.360.4312588821.kt
color_sberprime_react-native--canary.360.4312588821.ts
color_selgros_ios-swift--canary.360.4312588821.swift
color_selgros_kotlin--canary.360.4312588821.kt
color_selgros_react-native--canary.360.4312588821.ts
color_smbusiness_ios-swift--canary.360.4312588821.swift
color_smbusiness_kotlin--canary.360.4312588821.kt
color_smbusiness_react-native--canary.360.4312588821.ts
PlasmaTokensColor--canary.360.4312588821.swift
shadow_sbermarket_react-native--canary.360.4312588821.ts
typo_mage_ios-swift--canary.360.4312588821.swift
typo_mage_kotlin--canary.360.4312588821.kt
typo_mage_react-native--canary.360.4312588821.ts
typo_plasma_ios-swift--canary.360.4312588821.swift
typo_plasma_kotlin--canary.360.4312588821.kt
typo_plasma_react-native--canary.360.4312588821.ts
typo_ruler_ios-swift--canary.360.4312588821.swift
typo_ruler_kotlin--canary.360.4312588821.kt
typo_ruler_react-native--canary.360.4312588821.ts
typo_sage_ios-swift--canary.360.4312588821.swift
typo_sage_kotlin--canary.360.4312588821.kt
typo_sage_react-native--canary.360.4312588821.ts
typo_sbermarket_ios-swift--canary.360.4312588821.swift
typo_sbermarket_kotlin--canary.360.4312588821.kt
typo_sbermarket_react-native--canary.360.4312588821.ts
typo_soulmate_ios-swift--canary.360.4312588821.swift
typo_soulmate_kotlin--canary.360.4312588821.kt
typo_soulmate_react-native--canary.360.4312588821.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-b2c@1.148.0-canary.360.4312588821.0
npm install @salutejs/plasma-core@1.100.0-canary.360.4312588821.0
npm install @salutejs/plasma-hope@0.7.0-canary.360.4312588821.0
npm install @salutejs/plasma-icons@1.128.0-canary.360.4312588821.0
npm install @salutejs/plasma-temple@1.139.0-canary.360.4312588821.0
npm install @salutejs/plasma-ui@1.172.0-canary.360.4312588821.0
npm install @salutejs/plasma-web@1.173.0-canary.360.4312588821.0
npm install @salutejs/plasma-sb-utils@0.98.0-canary.360.4312588821.0
# or 
yarn add @salutejs/plasma-b2c@1.148.0-canary.360.4312588821.0
yarn add @salutejs/plasma-core@1.100.0-canary.360.4312588821.0
yarn add @salutejs/plasma-hope@0.7.0-canary.360.4312588821.0
yarn add @salutejs/plasma-icons@1.128.0-canary.360.4312588821.0
yarn add @salutejs/plasma-temple@1.139.0-canary.360.4312588821.0
yarn add @salutejs/plasma-ui@1.172.0-canary.360.4312588821.0
yarn add @salutejs/plasma-web@1.173.0-canary.360.4312588821.0
yarn add @salutejs/plasma-sb-utils@0.98.0-canary.360.4312588821.0

@Yakutoc Yakutoc self-assigned this Feb 20, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-360/

@salute-developers salute-developers deleted a comment from Salute-Eva Feb 21, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 21, 2023
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-360/

@salute-developers salute-developers deleted a comment from Salute-Eva Feb 21, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 21, 2023
@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-360/
ui storybook: http://plasma.sberdevices.ru/pr/pr-360/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-360/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-360/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-360/temple-storybook/

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Yakutoc Yakutoc marked this pull request as ready for review February 21, 2023 02:48
Yeti-or
Yeti-or reviewed Feb 21, 2023
View reviewed changes
packages/plasma-b2c/src/components/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/plasma-b2c/src/components/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/plasma-b2c/src/components/Tabs/TabItem.tsx Outdated Show resolved Hide resolved
packages/plasma-core/api/plasma-core.api.md Outdated Show resolved Hide resolved
packages/plasma-core/src/components/Slider/Double.tsx Show resolved Hide resolved
packages/plasma-core/src/components/Slider/Thumb.tsx Outdated Show resolved Hide resolved
reports/plasma-hope-diff.diff Outdated Show resolved Hide resolved
packages/plasma-b2c/api/plasma-b2c.api.md Show resolved Hide resolved
@Yakutoc Yakutoc mentioned this pull request Feb 22, 2023
Merged
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 22, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-360/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-360/

1 similar comment
@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-360/

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-360/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-360/
ui storybook: http://plasma.sberdevices.ru/pr/pr-360/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-360/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-360/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-360/temple-storybook/

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🔴 Fail

Check out comparison report in job artifacts!

@Yakutoc Yakutoc requested a review from Yeti-or March 1, 2023 09:49
@Yakutoc
feat(plasma-core): slider move to core
e94f8ff
@Yakutoc
feat(plasma-b2c): re-export slider component
e53ee19
@Yakutoc
feat(plasma-ui): re-export slider component
1a86ddc
@Yakutoc
feat(plasma-web): re-export slider component
c6a0636
@Yakutoc
feat(plasma-core): feat react-draggable
9cbf2f1
@Yakutoc
feat(plasma-hope): add SliderThumb
9303f89
@Yakutoc
feat(plasma-b2c): re-export SliderThumb from plasma-hope
8cb783c
@Yakutoc
feat(plasma-web): re-export SliderThumb from plasma-hope
be04403
@Yakutoc
feat(plasma-web): add cypress tests symlink
2512ea5
@Yakutoc
feat(plasma-web): add cypress Slider snapshots
58e6d23
@Yakutoc
feat(plasma-b2c): add cypress tests symlink
c57864e
@Yakutoc
feat(plasma-b2c): add cypress snapshots
cd2dac2
@Yakutoc
feat(plasma-b2c): delete unnecessary cypress snapshots
971213a
@Yakutoc
feat(plasma-ui): add cypress test symlink
686c281
@Yakutoc
feat(plasma-ui): add cypress snapshots
ea202ab
@Yakutoc
feat(plasma-ui): delete unnecessary cypress snapshots
fcca8b8
@Yakutoc
feat: add api reports after re-export Slider component
5cd320b
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-360/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-360/

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-360/
ui storybook: http://plasma.sberdevices.ru/pr/pr-360/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-360/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-360/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-360/temple-storybook/

@Yakutoc Yakutoc merged commit 2dd3217 into master Mar 2, 2023
@Yakutoc Yakutoc deleted the feat-slider-move-to-core branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@gibushnev gibushnev gibushnev approved these changes

Assignees

@Yakutoc Yakutoc

Labels
enhancement New feature or request plasma-ui plasma-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Yakutoc @Salute-Eva @Yeti-or @neretin-trike @gibushnev