Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-export "ElasticGrid" component #372

Merged
merged 8 commits into from Mar 3, 2023

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Feb 28, 2023

Необходимо:

  1. Перенести компонент из plasma-b2c в plasma-hope и сделать re-export в

    • plasma-b2c
    • plasma-web
  2. Проверить дизайн в plasma-web;

🐤 Download canary assets:

colors--canary.372.4319879506.xml
color_metro_ios-swift--canary.372.4319879506.swift
color_metro_kotlin--canary.372.4319879506.kt
color_metro_react-native--canary.372.4319879506.ts
color_sberHealth_ios-swift--canary.372.4319879506.swift
color_sberHealth_kotlin--canary.372.4319879506.kt
color_sberHealth_react-native--canary.372.4319879506.ts
color_sbermarket_ios-swift--canary.372.4319879506.swift
color_sbermarket_kotlin--canary.372.4319879506.kt
color_sbermarket_react-native--canary.372.4319879506.ts
color_sberprime_ios-swift--canary.372.4319879506.swift
color_sberprime_kotlin--canary.372.4319879506.kt
color_sberprime_react-native--canary.372.4319879506.ts
color_selgros_ios-swift--canary.372.4319879506.swift
color_selgros_kotlin--canary.372.4319879506.kt
color_selgros_react-native--canary.372.4319879506.ts
color_smbusiness_ios-swift--canary.372.4319879506.swift
color_smbusiness_kotlin--canary.372.4319879506.kt
color_smbusiness_react-native--canary.372.4319879506.ts
PlasmaTokensColor--canary.372.4319879506.swift
shadow_sbermarket_react-native--canary.372.4319879506.ts
typo_mage_ios-swift--canary.372.4319879506.swift
typo_mage_kotlin--canary.372.4319879506.kt
typo_mage_react-native--canary.372.4319879506.ts
typo_plasma_ios-swift--canary.372.4319879506.swift
typo_plasma_kotlin--canary.372.4319879506.kt
typo_plasma_react-native--canary.372.4319879506.ts
typo_ruler_ios-swift--canary.372.4319879506.swift
typo_ruler_kotlin--canary.372.4319879506.kt
typo_ruler_react-native--canary.372.4319879506.ts
typo_sage_ios-swift--canary.372.4319879506.swift
typo_sage_kotlin--canary.372.4319879506.kt
typo_sage_react-native--canary.372.4319879506.ts
typo_sbermarket_ios-swift--canary.372.4319879506.swift
typo_sbermarket_kotlin--canary.372.4319879506.kt
typo_sbermarket_react-native--canary.372.4319879506.ts
typo_soulmate_ios-swift--canary.372.4319879506.swift
typo_soulmate_kotlin--canary.372.4319879506.kt
typo_soulmate_react-native--canary.372.4319879506.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-b2c@1.152.0-canary.372.4319879506.0
npm install @salutejs/plasma-hope@0.11.0-canary.372.4319879506.0
npm install @salutejs/plasma-web@1.177.0-canary.372.4319879506.0
# or 
yarn add @salutejs/plasma-b2c@1.152.0-canary.372.4319879506.0
yarn add @salutejs/plasma-hope@0.11.0-canary.372.4319879506.0
yarn add @salutejs/plasma-web@1.177.0-canary.372.4319879506.0

@Yakutoc Yakutoc added enhancement New feature or request plasma-web labels Feb 28, 2023
@Yakutoc Yakutoc self-assigned this Feb 28, 2023
@Yakutoc Yakutoc force-pushed the feat-re-export-elastic-grid-component branch from 9b61a12 to daf0d4d Compare February 28, 2023 06:06
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 28, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 28, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 28, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Feb 28, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-372/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-372/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Yakutoc Yakutoc marked this pull request as ready for review February 28, 2023 07:55
@Yakutoc Yakutoc force-pushed the feat-re-export-elastic-grid-component branch from daf0d4d to e309ec2 Compare March 2, 2023 05:27
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-372/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-372/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Yakutoc Yakutoc force-pushed the feat-re-export-elastic-grid-component branch from e309ec2 to 75fd1c4 Compare March 3, 2023 03:14
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-372/

@Salute-Eva
Copy link
Contributor

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-372/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out comparison report in job artifacts!

@Yakutoc Yakutoc merged commit f9c3b9c into master Mar 3, 2023
@Yakutoc Yakutoc deleted the feat-re-export-elastic-grid-component branch March 3, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plasma-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants