Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plasma-new-hope/b2c/web): add skeleton with new architecture #954

Merged
merged 6 commits into from Dec 28, 2023

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Dec 26, 2023

Skeleton

  • добавлен компонент скелетона в новой архитектуре
  • скелетон включен в поставку b2c/web
  • скелетон удален из plasma-hope
  • написаны тесты
  • поправлена ошибка в forwardRef компонента Calendar
  • поправлен компонент Button для использования в styled

What/why changed

Добавлен компонент скелетона в новой архитектуре.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.24.0-canary.954.7347497908.0
npm install @salutejs/plasma-b2c@1.265.0-canary.954.7347497908.0
npm install @salutejs/plasma-hope@1.252.0-canary.954.7347497908.0
npm install @salutejs/plasma-new-hope@0.31.0-canary.954.7347497908.0
npm install @salutejs/plasma-web@1.265.0-canary.954.7347497908.0
# or 
yarn add @salutejs/plasma-asdk@0.24.0-canary.954.7347497908.0
yarn add @salutejs/plasma-b2c@1.265.0-canary.954.7347497908.0
yarn add @salutejs/plasma-hope@1.252.0-canary.954.7347497908.0
yarn add @salutejs/plasma-new-hope@0.31.0-canary.954.7347497908.0
yarn add @salutejs/plasma-web@1.265.0-canary.954.7347497908.0

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-954/

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-954/

Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-954/

@Salute-Eva
Copy link
Contributor

Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

const [linesWidth, setLinesWidth] = useState([]);

useEffect(() => {
if (!width) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут кажется теперь пофиксили этот баг
#230
наверное надо будет его закрыть как вольем? Хотя для ui он еще остался...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, остался для UI поэтому issue не стал цеплять

@Salute-Eva
Copy link
Contributor

Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-954/

@Salute-Eva
Copy link
Contributor

Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Dec 28, 2023
Merged via the queue into dev with commit 11698b5 Dec 28, 2023
25 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2271/refactor-skeleton branch December 28, 2023 13:26
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/plasma-asdk@0.24.0-dev.0, @salutejs/plasma-b2c@1.265.0-dev.0, @salutejs/plasma-hope@1.252.0-dev.0, @salutejs/plasma-new-hope@0.31.0-dev.0, @salutejs/plasma-temple-docs@0.202.0-dev.0, @salutejs/plasma-ui-docs@0.251.0-dev.0, @salutejs/plasma-web-docs@0.219.0-dev.0, @salutejs/plasma-web@1.265.0-dev.0, @salutejs/plasma-website@0.227.0-dev.0 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/plasma-asdk@0.24.0-dev.0, @salutejs/plasma-b2c@1.265.0-dev.0, @salutejs/plasma-hope@1.252.0-dev.0, @salutejs/plasma-new-hope@0.31.0-dev.0, @salutejs/plasma-temple-docs@0.202.0-dev.0, @salutejs/plasma-ui-docs@0.251.0-dev.0, @salutejs/plasma-web-docs@0.219.0-dev.0, @salutejs/plasma-web@1.265.0-dev.0, @salutejs/plasma-website@0.227.0-dev.0 🚀

3 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/plasma-asdk@0.24.0-dev.0, @salutejs/plasma-b2c@1.265.0-dev.0, @salutejs/plasma-hope@1.252.0-dev.0, @salutejs/plasma-new-hope@0.31.0-dev.0, @salutejs/plasma-temple-docs@0.202.0-dev.0, @salutejs/plasma-ui-docs@0.251.0-dev.0, @salutejs/plasma-web-docs@0.219.0-dev.0, @salutejs/plasma-web@1.265.0-dev.0, @salutejs/plasma-website@0.227.0-dev.0 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/plasma-asdk@0.24.0-dev.0, @salutejs/plasma-b2c@1.265.0-dev.0, @salutejs/plasma-hope@1.252.0-dev.0, @salutejs/plasma-new-hope@0.31.0-dev.0, @salutejs/plasma-temple-docs@0.202.0-dev.0, @salutejs/plasma-ui-docs@0.251.0-dev.0, @salutejs/plasma-web-docs@0.219.0-dev.0, @salutejs/plasma-web@1.265.0-dev.0, @salutejs/plasma-website@0.227.0-dev.0 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/plasma-asdk@0.24.0-dev.0, @salutejs/plasma-b2c@1.265.0-dev.0, @salutejs/plasma-hope@1.252.0-dev.0, @salutejs/plasma-new-hope@0.31.0-dev.0, @salutejs/plasma-temple-docs@0.202.0-dev.0, @salutejs/plasma-ui-docs@0.251.0-dev.0, @salutejs/plasma-web-docs@0.219.0-dev.0, @salutejs/plasma-web@1.265.0-dev.0, @salutejs/plasma-website@0.227.0-dev.0 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/plasma-asdk@0.29.0, @salutejs/plasma-b2c@1.271.0, @salutejs/plasma-core@1.144.0, @salutejs/plasma-cy-utils@0.76.0, @salutejs/plasma-hope@1.255.0, @salutejs/plasma-icons@1.177.0, @salutejs/plasma-new-hope@0.35.0, @salutejs/plasma-sb-utils@0.142.0, @salutejs/plasma-temple-docs@0.209.0, @salutejs/plasma-temple@1.196.0, @salutejs/plasma-tokens-b2b@1.33.0, @salutejs/plasma-tokens-b2c@0.43.0, @salutejs/plasma-tokens-native@1.19.0, @salutejs/plasma-tokens-utils@0.37.0, @salutejs/plasma-tokens-web@1.48.0, @salutejs/plasma-tokens@1.68.0, @salutejs/plasma-ui-docs@0.258.0, @salutejs/plasma-ui@1.228.0, @salutejs/plasma-web-docs@0.225.0, @salutejs/plasma-web@1.271.0, @salutejs/plasma-website@0.233.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants