Adjust readme #54
Merged
Adjust readme #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sgnilreutr
commented
Nov 22, 2021
sgnilreutr
commented
- Move Abstract section into Main Goal
- Add Table of Contents
- Structure document with correct headings
- Textual changes, grammar.
- Add Saga + Thunk examples
Add saga and redux thunk examples
Add table of contents
Adjust indent
Textual changes
|
Hi, @sgnilreutr thanks for the great work! I'll review it soon! |
salvoravida
reviewed
Nov 26, 2021
| @@ -151,12 +180,14 @@ const App = () => ( | |||
| ); | |||
|
|
|||
| export default App; | |||
|
|
|||
| //...History can now be used via other components using history.push() etc. | |||
| ``` | |||
There was a problem hiding this comment.
What's the goal of this comment?
There was a problem hiding this comment.
I wanted to emphasise that by implementing redux first history the behaviour of a function such as history.push or navigate() remains the same.
There was a problem hiding this comment.
@salvoravida Is there anything else you'd like to have changed before it can be merged?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.