Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set move_group capabilities by checking the existence of 'capabilities' key in move_group_capabilities dict #1

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

SyZbidi
Copy link
Member

@SyZbidi SyZbidi commented May 31, 2024

Description

I encountered this error [ERROR] [launch]: Caught exception in launch (see debug for traceback): 'capabilities' mentioned in #2734

Now capabilities is set by checking if the key capabilities in move_group_capabilities dict exists or not as it might come in handy if I'm going to use MTC as explained in the PR comment that passed those capabilities to launches.py

@gavanderhoorn gavanderhoorn changed the base branch from main to main-on-humble June 4, 2024 17:25
@gavanderhoorn
Copy link
Member

Could you please update the description here?

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
@SyZbidi SyZbidi changed the title make it a choice to load move_group capabilities Set move_group capabilities by checking the existence of 'capabilities' key in move_group_capabilities dict Jun 5, 2024
@SyZbidi
Copy link
Member Author

SyZbidi commented Jun 5, 2024

Could you please update the description here?

done

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll merge this here, but I'd really like to find something less 'work-around-y' at some point.

@gavanderhoorn gavanderhoorn merged commit 1fb55a2 into main-on-humble Jun 5, 2024
@gavanderhoorn gavanderhoorn deleted the make_capabilities_an_arg branch June 5, 2024 10:13
@SyZbidi
Copy link
Member Author

SyZbidi commented Jun 5, 2024

thanks @gavanderhoorn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants