This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
Add token pass-thru for AuthConfig #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to moby/moby/pull/17741 |
dhiltgen
pushed a commit
to dhiltgen/swarm
that referenced
this pull request
Nov 6, 2015
Once samalba/dockerclient#184 is merged, this will be replaced by a proper vendoring of that change. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
This extends the AuthConfig to allow token pass-thru and augments the CreateContainer API to set the X-Registry-Auth header if an AuthConfig is passed in. This will allow Swarm to pull private images on specific nodes based on container creation. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
dhiltgen
pushed a commit
to dhiltgen/swarm
that referenced
this pull request
Nov 11, 2015
Once samalba/dockerclient#184 is merged, this will be replaced by a proper vendoring of that change. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
|
LGTM -- we shouldn't merge until moby/moby#17741 is merged. |
|
LGTM. |
|
LGTM |
abronan
added a commit
that referenced
this pull request
Dec 7, 2015
Add token pass-thru for AuthConfig
dhiltgen
pushed a commit
to dhiltgen/dockerclient
that referenced
this pull request
Dec 8, 2015
This change keeps the mock client in sync with the recent change to the AuthConfig from PR samalba#184 Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
|
The README still needs to be updated for the new |
|
@djmaze are you interested in creating a pull request to fix that? |
djmaze
added a commit
to djmaze/dockerclient
that referenced
this pull request
Dec 26, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the AuthConfig to allow token pass-thru and augments the
CreateContainer API to set the X-Registry-Auth header if an AuthConfig
is passed in. This will allow Swarm to pull private images on specific
nodes based on container creation.
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com