-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
identityref coding-modulation does not cover all values #13
Comments
After the discussion we had in the weekly meeting, the proposal could be changed as in the description below. A new data type is defined with the grouping <acm-profile> which is composed of the following attributes: Where:
The <acm-profile-list> list of acm profiles indexed by <profile-id> must be added to the <capabilities> container. The list contains the acm profiles operated by the radio link for the selected channel separation. In other words, every time you change the value of <channel-separation> the device rebuilds the list. The elements of the acm profile list are doubly linked to each other via the <upper-profile> and <lower-profile> attributes. It is thus evident what will be the sequence of the profiles operated according to the fading conditions. The figure below shows these relationships. Having chosen to keep the identityref <coding-modulation> type for <profile-id>, <available-min-acm> and <available-max-acm> would 'point' respectively to the lowest and highest profile present in <acm-profile -list>. Choosing the identityref <coding-modulation> type for <profile-id> means keeping this type in the model which is not future-proof, but would be a good compromise for backward compatibility (A better defined model would require changing the type of <available-min-acm> and <available-max-acm> to leafref). In the /if:interfaces/if:interface augment, which contains the radio link configuration attributes, the <selected-min-acm> and <selected-max-acm> (or <selected-cm>) attributes must 'point ' to an element of the <acm-profile-list> list. Also for these attributes it is possible to maintain the type identityref <coding-modulation>. The proposed solution would bring the following benefits:
|
Now I understood the proposal. I agree to add the capabilities with the list of acm-profile (used also for fixed modulation) . Using the Few comments:
|
Discussed on 4 May 2023 call: Discussing Danilo's and Daniela's comments the following was decided to propose for the next draft of the YANG module: The acm-profile-list is added to the capabilities container. the acm-profile-list uses the grouping called acm-profile and is indexed by profile-coding-modulation-id and profile-channel-separation-id. Use a new attribute called nominal-tx-capacity, instead of code-rate and symbol-rate-reduction because the calculation of nominal-tx-capacity is derived from code-rate and symbol-rate-reduction by formulas that are not standardized and are specific to the equipment. So the nominal-tx-capacity value should be provided to avoid confusion on how to calculate it. Rename minimum-power to min-tx-power and maximum-available-power to max-tx-power. Discussion on upshift and downshift with the ONF, it is unclear how to fill out those values. Other issues related to atpc, need to be made into new issues. |
Update from 4 May: add: 8 PSK modulation |
Based on the latest proposal from Danilo the follwoing changes were suggested.
|
Implemented the first two bullets in Jonas' comment above. Need more information about the third bullet. |
For "The channel-separation and selected-cm configuration parameters Add: "If acm-profile-list is supported then the channel-separation and ... Update: Change acm-profile-list to be a YANG feature. And propose yang. Action to team: Check the list of coding-modulations to validate completeness. |
A few additional comments:
|
Having implemented the model in the 4th ETSI Plugtest for mw devices, we realized that the identityref coding-modulation does not provide all possible values. Some mw devices support 8 PSK modulation which is not included.
The use of identityrefs, even if it currently covers all values, also has the disadvantage of having to update the YANG model if new and more complex modulation schemes are standardized in the future.
A different approach could be taken to overcome this limitation. Let the device declare the acm profiles it supports, making explicit the parameters of each transmission ACM profile, and point to one of these in selected-min-acm, selected-max-acm or selected-cm.
Whereas each ACM profile is basically described by
to which generic parameters can be added, such as (for example) a descriptive name of the profile and a value to organize the profiles in ascending/descending order
the following structure could be assumed as an ACM profile entry:
}
From which it would also be possible to obtain the available radio capacity with the simple formula:
tx-capacity = channel-separation * log2(modulation-scheme) * code-rate / symbol-rate-reduction-factor / K ;
K takes into account the rolloff (approx. 1.15).
The device could only show the profiles of the selected channel-separation, if one accepted that the list containing the ACM profiles is not invariant over time. In this case, acm-profile grouping might not include the channel-separation attribute.
The selected-min-acm, selected-max-acm or selected-cm attributes should become leafrefs pointing to one of the ACM profiles.
With this approach, although complex, it is not necessary to maintain the identityref in the future.
Even the user who has to configure the ACM profiles would be facilitated in the setting, having the list of values supported by the device available.
The text was updated successfully, but these errors were encountered: