This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
Added directory/wildcard support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoSmudge
pushed a commit
that referenced
this pull request
Dec 13, 2012
Added directory/wildcard support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for directories with an optional file suffix. In other words the following paths are now supported:
In the first case if bar is a dir, all files in bar and its subfolders will be loaded. In the second case only the files ending in ".js" will be added.
It's a bit incomplete in that there's no way to add only files directly contained in the folder itself (and not its subfolders) and the wildcard doesn't allow prefixes. I would have used glob, except I can't find a way to make glob also search in subfolders and I favoured the more inclusive approach because this was born out of the need of having deep hierarchies of JS files that I don't want to have to keep track of in Squeezeit.