Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Added semicolons in JS concatenation #5

Merged
merged 2 commits into from Jan 8, 2013
Merged

Added semicolons in JS concatenation #5

merged 2 commits into from Jan 8, 2013

Conversation

pluma
Copy link
Contributor

@pluma pluma commented Jan 7, 2013

I kept on running into issues with JS files that do not end with a trailing semicolon followed by files that begin with an open parenthesis.

To resolve this within Squeezeit I've removed the concatenation from the generic load function and added it to the JS/CSS specific code. This means the load function now returns a list containing the loaded file contents rather than a single concatenated string.

There is probably a better way to do this, but this at least prevents concatenation-induced syntax errors.

YoSmudge pushed a commit that referenced this pull request Jan 8, 2013
Added semicolons in JS concatenation
@YoSmudge YoSmudge merged commit 7d6f760 into YoSmudge:master Jan 8, 2013
@YoSmudge
Copy link
Owner

YoSmudge commented Jan 8, 2013

This is good, thanks. It's an issue I've been running into since I started using the module patern but haven't had time to fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants