[WiP] New Job Name Validation

changelog.html

@@ -55,6 +55,164 @@
 
 <!-- Record your changes in the trunk here. -->
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
+<ul class=image>
+  <li class=>
+</ul>
+</div><!--=TRUNK-END=-->
+<h3><a name=v2.12>What's new in 2.12</a> (2016/07/05)</h3>
+<ul class=image>
+  <li class=rfe>
+    Enable the <code>DescriptorVisibilityFilter</code>s for ComputerLauncher, RetentionStrategy and NodeProperty.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-36280">Issue 36280</a>)
+  <li class=rfe>
+    Before starting a process, ensure that its working directory exists.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-36277">Issue 36277</a>)
+  <li class=bug>
+    Prevent <code>NullPointerException</code> during SCM polling if <code>SCMDecisionHandler</code> returns <code>null</code> veto.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-36232">Issue 36232</a>, regression in 2.11)
+  <li class=bug>
+    Ensure that <code>SCMDescriptor.newInstance</code> overrides are honored when creating new SCM entries.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-36043">Issue 36043</a>,
+     <a href="https://issues.jenkins-ci.org/browse/JENKINS-35906">Issue 35906</a>
+    , regression in 2.10)
+  <li class=bug>
+    Performance: Improve configuration page load times by removing the CodeMirror reloading cycle.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-32027">Issue 32027</a>)
+  <li class=bug>
+    Fix optional plugin dependency version resolution.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-21486">Issue 21486</a>, previous fix was reverted in Jenkins 2)
+  <li class=bug>
+    When creating a tar file, ensure that the final size does not exceed the value
+    in header in the case of growing files.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-20187">Issue 20187</a>)
+  <li class=bug>
+    Do not inject build variables into Maven process by default for new projects.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-25416">Issue 25416</a>, 
+     <a href="https://issues.jenkins-ci.org/browse/JENKINS-28790">Issue 28790</a>)
+  <li class=rfe>
+    Update <code>BUILD_TAG</code> environment variable description to mention the replacement of slashes with dashes.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/2417">PR #2417</a>)
+  <li class=rfe>
+    Internal API: Make <code>BulkChange</code> auto-closeable.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/2428">PR #2428</a>)
+</ul>
+<h3><a name=v2.11>What's new in 2.11</a> (2016/06/26)</h3>
+<ul class=image>
+  <li class=rfe>
+    Provide an extension point for SCM decisions such as whether to poll a specific job's backing
+    repository for changes.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-36123">Issue 36123</a>)
+</ul>
+<h3><a name=v2.10>What's new in 2.10</a> (2016/06/19)</h3>
+<ul class=image>
+  <li class=rfe>
+    Better exception message if a <code>SecurityRealm</code> returns null when loading a user.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/2407">PR #2407</a>)
+  <li class=bug>
+    Prevent <code>NullPointerException</code> in user registration if user ID is not specified.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-33600">Issue 33600</a>)
+  <li class=bug>
+    Internal: It was impossible to build Jenkins on 32-bit Linux machine.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-36052">Issue 36052, regression from 2.0</a>)
+</ul>
+<h3><a name=v2.9>What's new in 2.9</a> (2016/06/13)</h3>
+<ul class=image>
+  <li class=bug>
+    Always send usage statistics over HTTPs to the new usage.jenkins.io hostname.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35641">Issue 35641</a>)
+  <li class=bug>
+    Performance: Disable AutoBrowserHolder by default to improve the changelog rendering performance.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35098">Issue 35098</a>)
+  <li class=bug>
+    Remoting 2.60: Make the channel reader tolerant against Socket timeouts.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-22722">Issue 22722</a>)
+  <li class=bug>
+    Remoting 2.60: Proper handling of the <code>no_proxy</code> environment variable.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-32326">Issue 32326</a>)
+  <li class=bug>
+    Remoting 2.60: Do not invoke PingFailureAnalyzer for agent=>master ping failures.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35190">Issue 35190</a>)
+  <li class=bug>
+    Remoting 2.60: <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-31256">Issue 31256</a>) 
+  <li class=bug>
+    Remoting 2.60: Fix potential file handle leaks during the build agent (FKA slave) startup.
+    <a href="https://issues.jenkins-ci.org/browse/JENKINS-35190">Issue 35190</a>) 
+  <li class=rfe>
+    Internal: Upgrade Groovy to 2.4.7 to finalize the fix in Jenkins 2.7.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34751">Issue 34751</a>)
+  <li class=rfe>
+    API: Allow delegating <code>TaskListener</code> creation to build agent implementations.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34923">Issue 34923</a>)
+  <li class=rfe>
+    API: Restrict external usages of </code>jenkins.util.ResourceBundleUtil</code>.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35381">Issue 35381</a>)
+  <li class=rfe>
+    API: Make it easier for <code>UpdateSite</code>s to tweak the </code>InstallationJob</code>.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35402">Issue 35402</a>)
+</ul>
+<h3><a name=v2.8>What's new in 2.8</a> (2016/06/05)</h3>
+<ul class=image>
+  <li class=bug>
+    Explicitly declare compatibility of Windows build agent service with .NET Framework 4.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/2386">PR #2386</a>)
+  <li class=rfe>
+    API: Introduce new listener extension point for slave creation/update/deletion.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-33780">Issue 33780</a>)
+  <li class=rfe>
+    Lossless optimization sizes of PNG images in Jenkins.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/2379">PR #2379</a>)
+  <li class=bug>
+    Fix the repeatable item delete button layout in Safari.
+    Addresses Build Steps and other such configuration items.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35178">Issue 35178</a>)
+  <li class=bug>
+    Installation Wizard: Do not offer creating new admin user if the security is preconfigured.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34881">Issue 34881</a>)
+  <li class=bug>
+    Prevent <code>NullPointerException</code> on startup after update from Jenkins 2.5.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35206">Issue 35206</a>)
+  <li class=bug>
+    Honor noProxy settings from "Manage Jenkins > Manage Plugins > Advanced".
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-31915">Issue 31915</a>)
+  <li class=rfe>
+    Add <a href="http://hc.apache.org/httpclient-3.x/authentication.html#NTLM">NTLM support</a>
+    to the proxy validation logic.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/1955">PR #1955</a>)
+</ul>
+<h3><a name=v2.7>What's new in 2.7</a> (2016/05/29)</h3>
+<ul class=image>
+
+  <li class="bug">
+    Prevent stack overflow when using classes with complex generic type arguments 
+    (e.g. <code>hudson.model.Run</code> or <code>hudson.model.Job</code>).
+    Regression in Groovy 2.4, 
+    see <a href="https://issues.apache.org/jira/browse/GROOVY-7826">GROOVY-7826</a> for more info.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34751">issue 34751</a>)
+  <li class="bug">
+    Do not invoke <code>PingFailureAnalyzer</code> for agent=>master ping failures.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35190">issue 35190</a>)
+  <li class="bug">
+    Fix keyboard navigation in setup wizard.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-33947">issue 33947</a>)
+  <li class="bug">
+    Cleanup of Javascript issues discovered by the JSHint static analyis tool.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35020">issue 35020</a>)
+  <li class="bug">
+    <code>DelegatingComputerLauncher</code> now accepts child classes in its hooks
+    (pre-offline, pre-connect, etc.).
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35198">issue 35198</a>)
+  <li class="rfe">
+    Internal: Activate JSHint in Jenkins js-builder component during the core build.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34438">issue 34438</a>)
+  <li class="rfe">
+    Internal: Add symbol annotation for <code>SystemInfoLink</code>.
+    (<a href="https://github.com/jenkinsci/jenkins/pull/2375">PR #2375</a>)
+  <li class="bug">
+    Internal: NodeJS build was malfunctional on Win x64.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-35201">issue 35201</a>)
+</ul>
+<h3><a name=v2.6>What's new in 2.6</a> (2016/05/22)</h3>
 <ul class=image>
   <li class="major rfe">
     Adapt the Setup Wizard GUI to provide a similar user experience when upgrading Jenkins. 
@@ -74,7 +232,7 @@
     (<a href="https://github.com/jenkinsci/jenkins/pull/2353">PR 2353</a>)
   <li class="rfe">
     Added Symbol annotations for 
-    <code>ParametersDefinition</code> and <code>BuildDiscarder/code> properties. 
+    <code>ParametersDefinition</code> and <code>BuildDiscarder</code> properties. 
     (<a href="https://github.com/jenkinsci/jenkins/pull/2358">PR 2358</a>)
   <li class="rfe">
     Extended the <code>online-node</code> CLI command for accepting multiple agents. 
@@ -94,11 +252,13 @@
   <li class="bug">
     Do not show warnings abot a missing Tool Installer if it is present in at least one Update Site.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34880">issue 34880</a>)
+  <li class="bug">
+    Prevent hanging of the installation wizard due to the plugin status update issue.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-34708">issue 34708</a>)
   <li class="rfe">
     Internal: CLI command <code>connect-node</code> was extracted from the core to CLI. 
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-31417">issue 31417</a>)
 </ul>
-</div><!--=TRUNK-END=-->
 <h3><a name=v2.5>What's new in 2.5</a> (2016/05/16)</h3>
 <ul class=image>
   <li class="major bug">

cli/pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.jenkins-ci.main</groupId>
     <artifactId>pom</artifactId>
-    <version>2.6-SNAPSHOT</version>
+    <version>2.13-SNAPSHOT</version>
   </parent>
 
   <artifactId>cli</artifactId>

core/pom.xml

@@ -29,7 +29,7 @@ THE SOFTWARE.
   <parent>
     <groupId>org.jenkins-ci.main</groupId>
     <artifactId>pom</artifactId>
-    <version>2.6-SNAPSHOT</version>
+    <version>2.13-SNAPSHOT</version>
   </parent>
 
   <artifactId>jenkins-core</artifactId>
@@ -41,7 +41,7 @@ THE SOFTWARE.
     <staplerFork>true</staplerFork>
     <stapler.version>1.243</stapler.version>
     <spring.version>2.5.6.SEC03</spring.version>
-    <groovy.version>2.4.6</groovy.version>
+    <groovy.version>2.4.7</groovy.version>
   </properties>
 
   <dependencies>

core/src/main/java/hudson/BulkChange.java

@@ -25,6 +25,7 @@
 
 import hudson.model.Saveable;
 
+import java.io.Closeable;
 import java.io.IOException;
 
 /**
@@ -35,28 +36,13 @@
  * The usage of {@link BulkChange} needs to follow a specific closure-like pattern, namely:
  *
  * <pre>
- * BulkChange bc = new BulkChange(someObject);
- * try {
+ * try (BulkChange bc = new BulkChange(someObject)) {
  *    ... make changes to 'someObject'
- * } finally {
  *    bc.commit();
  * }
  * </pre>
  *
  * <p>
- * ... or if you'd like to avoid saving when something bad happens:
- *
- * <pre>
- * BulkChange bc = new BulkChange(someObject);
- * try {
- *    ... make changes to 'someObject'
- *    bc.commit();
- * } finally {
- *    bc.abort();
- * }
- * </pre>
- *
- * <p>
  * Use of this method is optional. If {@link BulkChange} is not used, individual mutator
  * will perform the save operation, and things will just run somewhat slower.
  *
@@ -82,7 +68,7 @@
  * @author Kohsuke Kawaguchi
  * @since 1.249
  */
-public class BulkChange {
+public class BulkChange implements Closeable {
     private final Saveable saveable;
     public final Exception allocator;
     private final BulkChange parent;
@@ -112,6 +98,14 @@ public void commit() throws IOException {
         saveable.save();
     }
 
+    /**
+     * Alias for {@link #abort()} to make {@link BulkChange} auto-closeable.
+     */
+    @Override
+    public void close() {
+        abort();
+    }
+
     /**
      * Exits the scope of {@link BulkChange} without saving the changes.
      *

core/src/main/java/hudson/Functions.java

@@ -25,6 +25,7 @@
  */
 package hudson;
 
+import hudson.model.Slave;
 import jenkins.util.SystemProperties;
 import hudson.cli.CLICommand;
 import hudson.console.ConsoleAnnotationDescriptor;
@@ -158,6 +159,7 @@
 import javax.annotation.CheckForNull;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
+import org.kohsuke.accmod.restrictions.DoNotUse;
 
 /**
  * Utility functions used in views.
@@ -889,10 +891,24 @@ public static List<SCMDescriptor<?>> getSCMDescriptors(AbstractProject<?,?> proj
         return SCM._for(project);
     }
 
+    /**
+     * @since 2.12
+     * @deprecated replaced by {@link Slave.SlaveDescriptor#computerLauncherDescriptors(Slave)}
+     */
+    @Deprecated
+    @Restricted(DoNotUse.class)
+    @RestrictedSince("2.12")
     public static List<Descriptor<ComputerLauncher>> getComputerLauncherDescriptors() {
         return Jenkins.getInstance().<ComputerLauncher,Descriptor<ComputerLauncher>>getDescriptorList(ComputerLauncher.class);
     }
 
+    /**
+     * @since 2.12
+     * @deprecated replaced by {@link Slave.SlaveDescriptor#retentionStrategyDescriptors(Slave)}
+     */
+    @Deprecated
+    @Restricted(DoNotUse.class)
+    @RestrictedSince("2.12")
     public static List<Descriptor<RetentionStrategy<?>>> getRetentionStrategyDescriptors() {
         return RetentionStrategy.all();
     }
@@ -913,6 +929,13 @@ public static List<Descriptor<MyViewsTabBar>> getMyViewsTabBarDescriptors() {
         return MyViewsTabBar.all();
     }
 
+    /**
+     * @deprecated replaced by {@link Slave.SlaveDescriptor#nodePropertyDescriptors(Slave)}
+     * @since 2.12
+     */
+    @Deprecated
+    @Restricted(DoNotUse.class)
+    @RestrictedSince("2.12")
     public static List<NodePropertyDescriptor> getNodePropertyDescriptors(Class<? extends Node> clazz) {
         List<NodePropertyDescriptor> result = new ArrayList<NodePropertyDescriptor>();
         Collection<NodePropertyDescriptor> list = (Collection) Jenkins.getInstance().getDescriptorList(NodeProperty.class);

core/src/main/java/hudson/PluginManager.java

@@ -40,6 +40,7 @@
 import hudson.model.UpdateSite;
 import hudson.model.UpdateCenter.DownloadJob;
 import hudson.model.UpdateCenter.InstallationJob;
+import hudson.security.ACL;
 import hudson.security.Permission;
 import hudson.security.PermissionScope;
 import hudson.util.CyclicGraphDetector;
@@ -61,6 +62,8 @@
 
 import net.sf.json.JSONArray;
 import net.sf.json.JSONObject;
+
+import org.acegisecurity.Authentication;
 import org.apache.commons.fileupload.FileItem;
 import org.apache.commons.fileupload.disk.DiskFileItemFactory;
 import org.apache.commons.fileupload.servlet.ServletFileUpload;
@@ -1319,6 +1322,7 @@ private List<Future<UpdateCenter.UpdateCenterJob>> install(@Nonnull Collection<S
     private void trackInitialPluginInstall(@Nonnull final List<Future<UpdateCenter.UpdateCenterJob>> installJobs) {
         final Jenkins jenkins = Jenkins.getInstance();
         final UpdateCenter updateCenter = jenkins.getUpdateCenter();
+        final Authentication currentAuth = Jenkins.getAuthentication();
 
         if (!Jenkins.getInstance().getInstallState().isSetupComplete()) {
             jenkins.setInstallState(InstallState.INITIAL_PLUGINS_INSTALLING);
@@ -1348,7 +1352,12 @@ public void run() {
                     }
                     updateCenter.persistInstallStatus();
                     if(!failures) {
-                        InstallUtil.proceedToNextStateFrom(InstallState.INITIAL_PLUGINS_INSTALLING);
+                        ACL.impersonate(currentAuth, new Runnable() {
+                            @Override
+                            public void run() {
+                                InstallUtil.proceedToNextStateFrom(InstallState.INITIAL_PLUGINS_INSTALLING);
+                            }
+                        });
                     }
                 }
             }.start();

core/src/main/java/hudson/PluginWrapper.java

@@ -209,17 +209,22 @@ public Dependency(String s) {
             if(idx==-1)
                 throw new IllegalArgumentException("Illegal dependency specifier "+s);
             this.shortName = s.substring(0,idx);
-            this.version = s.substring(idx+1);
-            
+            String version = s.substring(idx+1);
+
             boolean isOptional = false;
-            String[] osgiProperties = s.split(";");
+            String[] osgiProperties = version.split("[;]");
             for (int i = 1; i < osgiProperties.length; i++) {
                 String osgiProperty = osgiProperties[i].trim();
                 if (osgiProperty.equalsIgnoreCase("resolution:=optional")) {
                     isOptional = true;
                 }
             }
             this.optional = isOptional;
+            if (isOptional) {
+                this.version = osgiProperties[0];
+            } else {
+                this.version = version;
+            }
         }
 
         @Override