Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue no #96 #113

Merged
merged 5 commits into from
Mar 27, 2021
Merged

Fix issue no #96 #113

merged 5 commits into from
Mar 27, 2021

Conversation

RituCs
Copy link
Contributor

@RituCs RituCs commented Mar 14, 2021

Add footer for RocketMeet Client.
Screenshot from 2021-03-14 22-03-55

@anandbaburajan
Copy link
Member

Hey @RituCs! Thank you for your contribution! I've some suggestions - actually they're the same I mentioned at Gitter like those underlines and the footer width. PTAL, thanks! :D Also if you like, we can remove that octocat and just put Github in the follow us section. What do you think? You can remove the RocketMeet logo from the footer and just put a text.

@anandbaburajan anandbaburajan linked an issue Mar 15, 2021 that may be closed by this pull request
@RituCs
Copy link
Contributor Author

RituCs commented Mar 16, 2021

Hey @RituCs! Thank you for your contribution! I've some suggestions - actually they're the same I mentioned at Gitter like those underlines and the footer width. PTAL, thanks! :D Also if you like, we can remove that octocat and just put Github in the follow us section. What do you think? You can remove the RocketMeet logo from the footer and just put a text.

Ok I will do what you have mentioned.I think it would be good if we remove the octocat and put Github link in follow us section.

@anandbaburajan
Copy link
Member

Thanks! Can you share a screenshot for our convenience? :D Also you need to fix the conflicts in package.json.

@RituCs
Copy link
Contributor Author

RituCs commented Mar 22, 2021

Thanks! Can you share a screenshot for our convenience? :D Also you need to fix the conflicts in package.json.

Yeah Sure.
Screenshot from 2021-03-22 22-03-05

@anandbaburajan
Copy link
Member

Looks better! Thank you! By the comments about 'floating' at Gitter, I meant something like this:
image
Also it would be nice if the links had some hover color changes.

@anastr0
Copy link
Contributor

anastr0 commented Mar 24, 2021

@RituCs Looks really good! Just what I had in mind. :D Thanks!

@RituCs
Copy link
Contributor Author

RituCs commented Mar 26, 2021

Looks better! Thank you! By the comments about 'floating' at Gitter, I meant something like this:
image
Also it would be nice if the links had some hover color changes

Is it ok??
Screenshot from 2021-03-27 00-22-05

@anandbaburajan
Copy link
Member

Perfect! Thanks!

@anandbaburajan anandbaburajan merged commit 0cc780d into samay-app:main Mar 27, 2021
@RituCs
Copy link
Contributor Author

RituCs commented Mar 27, 2021

Perfect! Thanks!

My pleasure.It was great experience.Thank you for your help throughout the process.Looking forward to contribute more. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding of a footer element
3 participants