Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really live reloading #61

Open
BigTows opened this issue Mar 2, 2024 · 3 comments
Open

Really live reloading #61

BigTows opened this issue Mar 2, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BigTows
Copy link

BigTows commented Mar 2, 2024

User case:
We utilize S3 storage to store our resource pack. This pack is loaded from our CI/CD pipelines, ensuring that any changes on the servers (such as Velocity) are ignored.

What if?
ForcePack automatically check headers of the http request, for example:
HEAD https://eu.amazonaws.com/textures/test.zip
Response Header is:

Name Value
Date Sat, 02 Mar 2024 07:17:37 GMT
Last-Modified Sat, 02 Mar 2024 07:17:37 GMT

The plugin can dynamically check these parameters and manage the update hash accordingly. I'm not referring to the /vforcepack reload command, as it can lead to a subpar user experience. (The user forcibly receives the resourcepack)

Instead, the plugin updates the hash automatically, ensuring that the player receives the updated resource pack during the next loading process. This streamlined approach enhances user experience by eliminating the need for manual intervention.

@BigTows
Copy link
Author

BigTows commented Mar 2, 2024

or support S3 api ;) But scheduled http request it's fine i guess.

@SamB440 SamB440 added the enhancement New feature or request label Mar 3, 2024
@SamB440
Copy link
Owner

SamB440 commented Mar 3, 2024

I feel like just expanding the reload command is a better option than a scheduled task.

Some sites won't include those headers.

@BigTows
Copy link
Author

BigTows commented Mar 8, 2024

I feel like just expanding the reload command is a better option than a scheduled task.

A HEAD request is lighter than a GET request.

Some sites won't include those headers.

  1. Configure the header for checking:
  2. In some cases, the plugin can send a GET request to verify, but it's not a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants