makefile: prevent passing an unknown --arch argument to docker #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that if the CONTAINER_CMD is docker that the --arch flag will not be passed to the container engine. Only pass an --arch flag (to podman) if BUILD_ARCH is set to some non-empty value. Signed-off-by: John Mulligan <jmulligan@redhat.com>
anoopcs9
requested changes
Jun 20, 2023
anoopcs9
approved these changes
Jun 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that if the CONTAINER_CMD is docker that the --arch flag will not be passed to the container engine. Only pass an --arch flag (to podman) if BUILD_ARCH is set to some non-empty value.