Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume nightly built Samba RPMs #50

Merged

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Oct 7, 2021

Fixes #45

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Oct 7, 2021

test-ad-server-kubernetes failed because we don't have AD DC components built with our nightly Samba RPMs. I'll enable and check.

@phlogistonjohn
Copy link
Collaborator

This looks very interesting, however I am not sure about adding the nightlies to our primary container file.
I think it would be better if we had additional contianer files like "Dockerfile.nightly" (as opposed to "Dockerfile.fedora") and then we could extend the Makefiles to push the nightly build based containers to an alternate tag. Perhaps something like "samba-server:next" or just "samba-server:nightly"

What do you think?

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Oct 7, 2021

This looks very interesting, however I am not sure about adding the nightlies to our primary container file. I think it would be better if we had additional contianer files like "Dockerfile.nightly" (as opposed to "Dockerfile.fedora") and then we could extend the Makefiles to push the nightly build based containers to an alternate tag. Perhaps something like "samba-server:next" or just "samba-server:nightly"

What do you think?

Make sense. I'll come up with the required changes.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dockerfile looks good, however I think a slightly different approach with the makefile would be better. Let me know what you think.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long on this. Feel free to ping me in the future if I take more than a week to reply to a PR.
Anyway, one small change requested but everything else looks OK. In the future I think there's stuff we can do to perhaps minimize some duplication but I'd rather get this in now and deal with that later.

images/server/Dockerfile.nightly Outdated Show resolved Hide resolved
Signed-off-by: Anoop C S <anoopcs@samba.org>
Signed-off-by: Anoop C S <anoopcs@samba.org>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a bunch!

@phlogistonjohn phlogistonjohn merged commit f9a0fdd into samba-in-kubernetes:master Oct 20, 2021
@anoopcs9 anoopcs9 deleted the consume-nightly-samba-rpms branch October 21, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic up-to-date containers using nightly samba builds
2 participants