Skip to content

Commit

Permalink
vfs: Remove aio_linux
Browse files Browse the repository at this point in the history
Triggered by https://bugzilla.samba.org/show_bug.cgi?id=13128 I think
this module should go. Once Linux aio will do what Samba needs, this
might be worth another look.

What we should instead do soon is support Linux preadv2 and the
RWF_NOWAIT flag to avoid the thread context switch whenever possible.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
  • Loading branch information
vlendec authored and jrasamba committed Nov 11, 2017
1 parent 20cfcb7 commit 6381044
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 496 deletions.
9 changes: 9 additions & 0 deletions WHATSNEW.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ commands have been removed from rpcclient.
"net rpc vampire keytab" from Active Directory domains continues to be
supported.

vfs_aio_linux module removed
============================

The current Linux kernel aio does not match what Samba would
do. Shipping code that uses it leads people to false
assumptions. Samba implements async I/O based on threads by default,
there is no special module required to see benefits of read and write
request being sent do the disk in parallel.

KNOWN ISSUES
============

Expand Down
115 changes: 0 additions & 115 deletions docs-xml/manpages/vfs_aio_linux.8.xml

This file was deleted.

1 change: 0 additions & 1 deletion docs-xml/wscript_build
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ manpages='''
manpages/vfs_acl_tdb.8
manpages/vfs_acl_xattr.8
manpages/vfs_aio_fork.8
manpages/vfs_aio_linux.8
manpages/vfs_aio_pthread.8
manpages/vfs_audit.8
manpages/vfs_btrfs.8
Expand Down
Loading

0 comments on commit 6381044

Please sign in to comment.