Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix little typo in README file #41

Merged
merged 1 commit into from Dec 3, 2015
Merged

Fix little typo in README file #41

merged 1 commit into from Dec 3, 2015

Conversation

GuillaumeGomez
Copy link
Contributor

No description provided.

bjacke added a commit that referenced this pull request Dec 3, 2015
@bjacke
Merge pull request #41 from GuillaumeGomez/patch-1
4bccbed 
Fix little typo in README file

Reviewed-by: Bjoern Jacke <bj@sernet.de>
@bjacke bjacke merged commit 4bccbed into samba-team:master Dec 3, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch December 3, 2015 15:06
@abartlet
Copy link
Member

abartlet commented Dec 3, 2015

Sadly one of the downsides of the way that the Samba Team uses github is that you can't directly merge. You need to go via autobuild.

This merge will be undone as soon as I disable to force-push protection and the mirror script runs again.

@GuillaumeGomez
Copy link
Contributor Author

Well, whatever. I won't report the change myself, so I guess someone from the samba team (or someone else) will have to do it. At least, now you know it exists.

@abartlet
Copy link
Member

abartlet commented Dec 3, 2015

@GuillaumeGomez I'm sorry I wasn't clear, this isn't your issue. My comment was to @bjacke who is on the Samba Team, and so can get the code reviewed and submitted via the normal methods.

We realise this is very confusing (and contrary to standard github workflow), but we will get your change in shortly.

Thanks!

@GuillaumeGomez
Copy link
Contributor Author

Oh my bad. Well, like I said, the goal was to fix the typo, so as long as it's fixed at the end, it's fine for me.

@abartlet
Copy link
Member

abartlet commented Dec 4, 2015

Merged as 2a55a0b

abmas pushed a commit to abmas/samba that referenced this pull request Jun 20, 2018
Merge pull request samba-team#41 in PKG/samba from ~ARAMAKRISHNAN/sam…
e271406 
…ba1:debian/dvm6 to debian/dvm6

* commit 'e6bfb91cdb27c5882843b3f2de4a62693c57039b':
  Patch for HYP-5651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@GuillaumeGomez @abartlet @bjacke