Python ldb Py_ssize_t fixes #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set_component() This ensures we do not over-read the source buffer, but still NUL terminate. This may be related to debuain bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808769 Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
…PyArg_ParseTuple*() This was inconsistent after dd7baa2, and may be the cause of test errors on s390x. (The change to py_ldb_dn_set_component() kept the Py_ssize_t type for 'size' without setting the PY_SSIZE_T_CLEAN macro to have PyArg_ParseTuple() expect a Py_ssize_t. Instead, PyArg_ParseTuple() expected an int. See in particular debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808769 Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This changes the type used for # arguments to PyArg_ParseTuple Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This changes the type used for # arguments to PyArg_ParseTuple Signed-off-by: Andrew Bartlett <abartlet@samba.org>
We require Python 2.6 Signed-off-by: Andrew Bartlett <abartlet@samba.org>
This ensures that it is not concatonated with the previous option Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
Reviewed-By: me Thanks! |
|
Merged as 78e9f1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues on s390x in recent ldb, by being strict about always using py_ssize_t
I also clean up some code supporting Python 2.4, which we no longer support