Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-xml: Sort input file list #87

Closed
wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link
Contributor

because filesystems return entries in undeterministic order
and that ends up in index.xml and influences index.html
preventing reproducible builds of samba packages (e.g. for openSUSE)

See https://reproducible-builds.org/ for why this matters

Signed-off-by: Bernhard M. Wiedemann bwiedemann@suse.de

because filesystems return entries in undeterministic order
and that ends up in index.xml and influences index.html
preventing reproducible builds of samba packages (e.g. for openSUSE)

See https://reproducible-builds.org/ for why this matters

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@abartlet
Copy link
Member

Thanks. If it isn't too much trouble can you re-send to samba-technical manually? it looks great, but sadly the mailing list integration broke a while back and I need to fix it.

The only other thing is:

  • why is OpenSUSE using the docs-xml makefile at all? It really should just be used for the 'make dist' on our end, the normal waf build should build the docs by default.

@bmwiedemann
Copy link
Contributor Author

bmwiedemann commented Jun 26, 2017

I now sent it to samba-technical with git send-email => https://lists.samba.org/archive/samba-technical/2017-June/121300.html
Don't know why our samba does build this way (I'm not the maintainer), but @ddiss is.

https://build.opensuse.org/package/view_file/openSUSE:Factory/samba/samba.spec line 1133 has

pushd docs-xml
autoconf && ./configure
XML_CATALOG_FILES="file:///etc/xml/catalog file://$(pwd)/build/catalog.xml" make htmlman

@ddiss
Copy link
Contributor

ddiss commented Jun 26, 2017

@abartlet : for openSUSE we build Samba directly from the git source, rather than the release tarball. This means that we need to handle the docs build. I've responded to the patch via the ML.

@abartlet
Copy link
Member

Sure, but is there something this is building that the main waf build doesn't build that you need, rather than just have historically got? Do you really need HTML man pages?

The docs build via the makefiles is not as accurate, as the paths are not correctly set.

If you build manpages from the waf build, we fill in the correct paths into the docs based on the configure output. Sadly only man manpages are delivered.

@ddiss
Copy link
Contributor

ddiss commented Jun 26, 2017

We package the HTML man pages via a separate samba-docs package. We're also manually invoking "make manpages" for ctdb manpage generation.

The spec file and source tarball (generated from Git) can be found at:
https://build.opensuse.org/package/show/network:samba:STABLE/samba

@bjacke
Copy link
Contributor

bjacke commented Nov 11, 2017

was applied with eedebe2
Thanks!

@bjacke bjacke closed this Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants