Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Implement EveryBy/SomeBy/None/NoneBy #67

Merged
merged 5 commits into from
Apr 28, 2022
Merged

[Feature]: Implement EveryBy/SomeBy/None/NoneBy #67

merged 5 commits into from
Apr 28, 2022

Conversation

CorentinClabaut
Copy link
Contributor

No description provided.

@CorentinClabaut
Copy link
Contributor Author

Implements #54

@samber samber mentioned this pull request Apr 11, 2022
Merged
@CorentinClabaut CorentinClabaut mentioned this pull request Apr 12, 2022
Closed
@CorentinClabaut CorentinClabaut changed the title [Feature]: Implement All/Any/None [Feature]: Implement EveryBy/SomeBy/None/NoneBy Apr 12, 2022
@CorentinClabaut
Copy link
Contributor Author

@samber Do you think further modifications should be made to this PR?

samber
samber requested changes Apr 28, 2022
View reviewed changes
Copy link
Owner

@samber samber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib ;)

In the comments, you wrote "or if the collection is empty". Do you mean "subset"?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
intersect.go Outdated Show resolved Hide resolved
intersect.go Show resolved Hide resolved
intersect.go Outdated Show resolved Hide resolved
intersect.go Show resolved Hide resolved
@CorentinClabaut
Copy link
Contributor Author

You are right, that's a mistake.

For Every/Some/None it should indeed be or if the subset is empty

But for EveryBy/SomeBy/NoneBy I think it should be or if the collection is empty, as we use a callback instead of a subset.

@samber samber merged commit 0978088 into samber:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samber samber samber requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CorentinClabaut @samber @a-rose