Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialization of user data #8

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

ferhatelmas
Copy link
Contributor

@ferhatelmas ferhatelmas commented Oct 27, 2023

Since error is already formatted by
default converter, it's not an error
anymore. Event.User.Data will be nil
because it's the first time used.
Handle is done under try so it will be doing
nothing silently if there is an error attribute
in the log line.

Since error is already formatted by
default converter, it's not an error
anymore. Event.User.Data will be nil
because it's the first time used.
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6b2ffd9) 0.00% compared to head (8aa2b25) 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main      #8   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines        145     147    +2     
=====================================
- Misses       145     147    +2     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
converter.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samber
Copy link
Owner

samber commented Oct 27, 2023

v2.2.1

@samber samber merged commit 4a3a6f7 into samber:main Oct 27, 2023
2 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/fix-nil-map branch October 27, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants