Skip to content

Commit

Permalink
Make changelog tool be more strict about suffixes (ansible#70909)
Browse files Browse the repository at this point in the history
* Bump antsibull-changelog version.

* Flag all dotfiles, except .keep and .gitkeep.

* Enable ignoring other fragment extensions.
  • Loading branch information
felixfontein committed Aug 6, 2020
1 parent 4e55b93 commit fbfc0f9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelogs/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ changes_file: changelog.yaml
changes_format: combined
keep_fragments: true
always_refresh: true
ignore_other_fragment_extensions: true
mention_ancestor: false
notesdir: fragments
prelude_section_name: release_summary
Expand Down
2 changes: 1 addition & 1 deletion test/lib/ansible_test/_data/requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ setuptools < 37 ; python_version == '2.6' # setuptools 37 and later require pyth
setuptools < 45 ; python_version == '2.7' # setuptools 45 and later require python 3.5 or later

# freeze antsibull-changelog for consistent test results
antsibull-changelog == 0.3.1
antsibull-changelog == 0.7.0

# freeze pylint and its requirements for consistent test results
astroid == 2.2.5
Expand Down
4 changes: 4 additions & 0 deletions test/lib/ansible_test/_data/sanity/code-smell/changelog.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ def main():
continue

if path.startswith('changelogs/fragments/.'):
if path in ('changelogs/fragments/.keep', 'changelogs/fragments/.gitkeep'):
continue

print('%s:%d:%d: file must not be a dotfile' % (path, 0, 0))
continue

ext = os.path.splitext(path)[1]
Expand Down

0 comments on commit fbfc0f9

Please sign in to comment.