Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert both cjs and esm modules support #108

Closed
samchon opened this issue Oct 10, 2022 · 0 comments
Closed

Revert both cjs and esm modules support #108

samchon opened this issue Oct 10, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right
Projects

Comments

@samchon
Copy link
Owner

samchon commented Oct 10, 2022

I'd succeeded to support both cjs and esm modules, by publishing js, mjs, d.ts, d.mts files at the same time, through developing custom builder program. However, it can cause duplicated class problem. If a library imports Vector of tstl as CSM and another library also imports Vector class of ESM, two Vector classes being considered as different class.

Therefore, I conclude this experiment as premature and decided to roll back.

However, I will keep the custom builder program for future.

@samchon samchon added enhancement New feature or request invalid This doesn't seem right labels Oct 10, 2022
@samchon samchon self-assigned this Oct 10, 2022
@samchon samchon added this to To do in v2.5 Update via automation Oct 10, 2022
samchon added a commit that referenced this issue Oct 10, 2022
Close #108 - revert both CSM and ESM support
v2.5 Update automation moved this from To do to Done Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Development

No branches or pull requests

1 participant