Deque.insert() should not use Deque.swap() directly

[samchon]

Summary

• TSTL Version: 2.2.1
• Expected behavior: Deque.insert() does not call Deque.swap()
• Actual behavior: Deque.insert() calls the Deque.swap()

Code occuring the bug

tstl/src/container/Deque.ts

Lines 457 to 463 in 816b9ea

	// INSERT ITEM SEQUENTIALLY
	deque._Insert_to_end(this.begin(), pos);
	deque._Insert_to_end(first, last);
	deque._Insert_to_end(pos, this.end());
	// AND SWAP THIS WITH THE TEMP
	this.swap(deque);

Detailed Story

ECol extends TSTL containers and dispatches CollectionEvents. The CollectionEvents are dispatched when its container's elements are inserted, erased or changed. Detailed types of those CollectionEvents are:

Type	Means	Dispatched By
"insert"	Elements are inserted	Container.insert()
"erase"	Elements are erased	Container.erase()
"refresh"	Elements are changed	Container.swap(), Iterator.set, ...

In ECol, DequeCollection extends Deque to dispatch CollectionEvents. As you can see from the above, DequeCollection.swap() dispatches "refresh" typed CollectionEvent. If Deque.insert() keeps using Deque.swap(), DequeCollection.insert() will dispatch not only "insert", but also "refresh" typed CollectionEvent, which is not valid.

To avoid the bad situation, Deque.insert() should not call Deque.swap() directly.