Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JsonFactory and SchemaFactory #20

Closed
samchon opened this issue Apr 21, 2022 · 0 comments
Closed

Refactor JsonFactory and SchemaFactory #20

samchon opened this issue Apr 21, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@samchon
Copy link
Owner

samchon commented Apr 21, 2022

Refactor JsonFactory and SchemaFactory to be much effiently. Especially, the JsonFactory code is too complicate and inefficient as it has hard coded to build the ts.Exression only for the fast-json-stringify Schema. I think creating a new ExpressionFactory who can use every typed value would be much powerful and efficient. Maybe, its code would be even much shorter than the JsonFactory

Therefore, rename the SchemaFactory to the MetadataFactory and separate the JsonFactory to the SchemaFactory and ExpressionFactory, who converts IMetadata to JSON schema and converts any instance to the ts.Expression.

@samchon samchon added the enhancement New feature or request label Apr 21, 2022
@samchon samchon self-assigned this Apr 21, 2022
@samchon samchon added this to To do in v2.0 update via automation Apr 21, 2022
v2.0 update automation moved this from To do to Done Apr 21, 2022
samchon added a commit that referenced this issue Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

1 participant