Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message when jsDocParsingMode is not hacked. #879

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Nov 22, 2023

As TypeScript starts skipping parsing JSDocComments since TypeScript v5.3 update but it is possible to revive the JSDocComments' parsing, by hacking the jsDocParsingMode value of tsc.js, I've decided to print a warning message from typia when the jsDocParsingMode value is not hacked.

Therefore, it is possible to running the typia as before even when the jsDocParsingMode has not benn hacked, and user can ignore the warning message if he (or she) does not use any comment tags and not generating any JSON schema with description comments in the application.

As TypeScript starts skipping parsing `JSDocComment`s since TypeScript v5.3 update but it is possible to revive the `JSDocComment`s' parsing, by hacking the `jsDocParsingMode` value of `tsc.js`, I've decided to print a warning message from `typia` when the `jsDocParsingMode` value is not hacked.

Therefore, it is possible to running the `typia` as before even when the `jsDocParsingMode` is not hacked, and user can ignore the warning message if he (or she) does not use any comment tags or not generating JSON schema with description comments.

- Related issue: microsoft/TypeScript#55739
@samchon samchon added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 22, 2023
@samchon samchon self-assigned this Nov 22, 2023
@samchon samchon added this to In progress in V5 Update via automation Nov 22, 2023
@samchon samchon merged commit 450e705 into v5.3 Nov 22, 2023
2 of 3 checks passed
V5 Update automation moved this from In progress to Done Nov 22, 2023
@samchon samchon deleted the features/wizard branch November 22, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant