Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement #865 - documentation #882

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

MarArMar
Copy link
Contributor

Note : maybe a dropdown would be better

Before submitting a Pull Request, please test your code.

If you created a new feature, then create the unit test function, too.

# COMPILE
npm run build

# RE-WRITE TEST PROGRAMS IF REQUIRED
npm run test:template

# BUILD TEST PROGRAM
npm run build:test

# DO TEST
npm run test

Learn more about the CONTRIBUTING

@samchon samchon changed the base branch from master to v5.3 November 26, 2023 14:29
@samchon samchon self-requested a review November 26, 2023 14:29
@samchon samchon self-assigned this Nov 26, 2023
@samchon samchon added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Nov 26, 2023
@samchon samchon added this to In progress in V5 Update via automation Nov 26, 2023
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit detailing

website/pages/docs/setup.mdx Show resolved Hide resolved
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the content to be a little bit detailed.

By the way, what about making a new section vite + sveltekit like your issue case?

import { sveltekit } from "@sveltejs/kit/vite";
import { defineConfig } from "vite";
import typescript from "rollup-plugin-typescript2";

export default defineConfig({
  esbuild: false,
  plugins: [
    typescript({
      include: ["../../**/*.ts+(|x)"],
      exclude: ["../../**/node_modules/**/*"],
    }),
    sveltekit(),
  ],
});

V5 Update automation moved this from In progress to Reviewer approved Nov 26, 2023
@samchon samchon merged commit ee76e15 into samchon:v5.3 Nov 26, 2023
1 check passed
V5 Update automation moved this from Reviewer approved to Done Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants