Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #893 - erase @internal tag from IMetadataDictionary. #895

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix #893 - erase @internal tag from IMetadataDictionary. #895

merged 1 commit into from
Nov 30, 2023

Conversation

samchon
Copy link
Owner

@samchon samchon commented Nov 30, 2023

Making typia.reflect.metadata<Types>() function, I'd taken a mistake that adding vulnerable @internal tag on the IMetadataDictionary type, so that makes compilation error when using that function.

This PR solves that problem.

@samchon
Fix #893 - erase @internal tag from IMetadataDictionary.
c85d940 
Making `typia.reflect.metadata<Types>()` function, I'd taken a mistake that adding vulnerable `@internal` tag on the `IMetadataDictionary` type, so that makes compilation error when using that function.

This PR solves that problem.
@samchon samchon added the bug Something isn't working label Nov 30, 2023
@samchon samchon added this to In progress in V5 Update via automation Nov 30, 2023
@samchon samchon self-assigned this Nov 30, 2023
samchon
samchon commented Nov 30, 2023
View reviewed changes
Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the problem.

@samchon samchon merged commit 0822daa into master Nov 30, 2023
3 checks passed
V5 Update automation moved this from In progress to Done Nov 30, 2023
@samchon samchon deleted the features/metadata branch November 30, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samchon samchon

Labels
bug Something isn't working
Projects
No open projects
V5 Update
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samchon