Fix #998 - Resolved parameter properties by TMP. #999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declare a class type with public parameter properties, and the class type has some private member variables too, the public parameter properties had not identified by
typia
when the class type casted to a pritmitive object type through TMP type likePrimitive
orResolved
.It was because TypeScript compiler API still consider the public members as parameter properties even when converted to the primitive object type through TMP (type meta programming) like
Resolved<T>
. Ths PR fixes the bug, by considering the special case of the TypeScript compiler API, so that same bug would not be occured more.For reference, if there's not any private members or no parameter properties being utilized in a class type, no error be occured. This is the extremely rare case I hadn't known. Thanks for @hambergerpls to reporting such special case.