remove alternative logging interface

include/wassail/common.hpp

@@ -52,18 +52,6 @@ namespace wassail {
     return fmt::vformat(fmt, {fmt::make_format_args(args...)});
   }
 
-  /*! \brief Basic interface to the internal logger
-   *
-   * This function is provided so that templated code and other
-   * public interfaces can use the internal logger without exposing
-   * the details of the internal logger interface.  This should not
-   * be used by user code.
-   *
-   * \param[in] log_level Log level
-   * \param[in] msg Log message
-   */
-  void logger(const log_level log_level, const std::string msg);
-
   /*! \brief Return the wassail library version */
   std::string version();
 

src/checks/rules_engine.cpp

@@ -5,6 +5,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "internal.hpp"
+
 #include <functional>
 #include <vector>
 #include <wassail/checks/rules_engine.hpp>
@@ -37,7 +39,8 @@ namespace wassail {
         }
       }
       catch (std::exception &e) {
-        logger(log_level::warn, e.what() + std::string(": ") + j.dump());
+        wassail::internal::logger()->warn(e.what() + std::string(": ") +
+                                          j.dump());
         r->issue = result::issue_t::MAYBE;
         r->detail = wassail::format(fmt_str.detail_maybe, e.what());
       }

src/common/logger.cpp

@@ -31,30 +31,4 @@ namespace wassail {
       return (logger);
     }
   } // namespace internal
-
-  void logger(const log_level log_level, const std::string msg) {
-    switch (log_level) {
-    case wassail::log_level::trace:
-      wassail::internal::logger()->trace(msg);
-      break;
-    case wassail::log_level::debug:
-      wassail::internal::logger()->debug(msg);
-      break;
-    case wassail::log_level::info:
-      wassail::internal::logger()->info(msg);
-      break;
-    case wassail::log_level::warn:
-      wassail::internal::logger()->warn(msg);
-      break;
-    case wassail::log_level::err:
-      wassail::internal::logger()->error(msg);
-      break;
-    case wassail::log_level::critical:
-      wassail::internal::logger()->critical(msg);
-      break;
-    default:
-      /* do nothing */
-      break;
-    }
-  }
 } // namespace wassail