resolve items flagged by lgtm scan

samcmill · Jan 27, 2020 · 26ba9c6 · 26ba9c6
1 parent 1af3f11
commit 26ba9c6
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 13 deletions.
diff --git a/src/data/remote_shell_command.cpp b/src/data/remote_shell_command.cpp
@@ -240,7 +240,7 @@ namespace wassail {
         channel.sendEof();
         channel.close();
       }
-      catch (ssh::SshException e) {
+      catch (ssh::SshException &e) {
         node.shell.stderr.append(e.getError());
       }
 

diff --git a/src/samples/python/check.py b/src/samples/python/check.py
@@ -16,12 +16,11 @@
 from __future__ import print_function
 
 import json
-import logging
 import sys
 
 try:
     import wassail
-except:
+except ModuleNotFoundError:
     # If the wassail module is installed in a non-default location,
     # you may need to set the PYTHONPATH environment variable to that
     # location.  Also use the same python version the module was built

diff --git a/src/samples/python/dump.py b/src/samples/python/dump.py
@@ -15,7 +15,7 @@
 
 try:
     import wassail
-except:
+except ModuleNotFoundError:
     # If the wassail module is installed in a non-default location,
     # you may need to set the PYTHONPATH environment variable to that
     # location.  Also use the same python version the module was built

diff --git a/src/samples/python/environment.py b/src/samples/python/environment.py
@@ -11,12 +11,10 @@
 
 import argparse
 import json
-import logging
-import sys
 
 try:
     import wassail
-except:
+except ModuleNotFoundError:
     # If the wassail module is installed in a non-default location,
     # you may need to set the PYTHONPATH environment variable to that
     # location.  Also use the same python version the module was built

diff --git a/src/samples/python/rest_server.py b/src/samples/python/rest_server.py
@@ -19,7 +19,7 @@
 
 try:
     import wassail
-except:
+except ModuleNotFoundError:
     # If the wassail module is installed in a non-default location,
     # you may need to set the PYTHONPATH environment variable to that
     # location.  Also use the same python version the module was built

diff --git a/src/samples/python/standalone.py b/src/samples/python/standalone.py
@@ -14,13 +14,9 @@
 
 from __future__ import print_function
 
-import json
-import logging
-import sys
-
 try:
     import wassail
-except:
+except ModuleNotFoundError:
     # If the wassail module is installed in a non-default location,
     # you may need to set the PYTHONPATH environment variable to that
     # location.  Also use the same python version the module was built