initialize pointer and add missing nvml python test

samcmill · Apr 6, 2020 · fae1db4 · fae1db4
1 parent a7afb11
commit fae1db4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/data/nvml.cpp b/src/data/nvml.cpp
@@ -153,7 +153,7 @@ namespace wassail {
 
     private:
 #ifdef WITH_DATA_NVML
-      void *handle; /*!< Library handle */
+      void *handle = nullptr; /*!< Library handle */
 
       void device_query(nvmlDevice_t device);
       nvml::impl::nvlink nvlink_query(nvmlDevice_t device, unsigned int link);

diff --git a/test/python/test_data.py b/test/python/test_data.py
@@ -93,6 +93,18 @@ def test_getrlimit(self):
             with self.assertRaises(RuntimeError):
                 d.evaluate()
 
+    def test_nvml(self):
+        """nvml data source"""
+        d = wassail.data.nvml()
+        if d.enabled():
+            d.evaluate()
+            s = str(d)
+            j = json.loads(s)
+            self.assertEqual(j['name'], 'nvml')
+        else:
+            with self.assertRaises(RuntimeError):
+                d.evaluate()
+
     def test_pciaccess(self):
         """pciaccess data source"""
         d = wassail.data.pciaccess()