You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Watching these updates roll in is very exciting :)
I wanted to just make a minor suggestion: the geopandas.points_from_xy can be significantly more efficient than the list comprehension + shapely.geometry.Point() strategy used here.
This is mainly because of efficiency gains made using pygeos, which vectorizes the creation of the points. I'd use this wherever you're casting from arrays to geopandas.Geo* containers.
The text was updated successfully, but these errors were encountered:
Thanks and great suggestion, I wasn't aware of this! I can see the performance gains are made from geopandashere conditional on pygeos being installed.
Will apply this in the next push. As ever, your feedback and review is always welcome.
Watching these updates roll in is very exciting :)
I wanted to just make a minor suggestion: the
geopandas.points_from_xy
can be significantly more efficient than the list comprehension +shapely.geometry.Point()
strategy used here.spacv/spacv/utils.py
Line 20 in 13f6303
This is mainly because of efficiency gains made using
pygeos
, which vectorizes the creation of the points. I'd use this wherever you're casting from arrays togeopandas.Geo*
containers.The text was updated successfully, but these errors were encountered: