Vectorized points_from_xy?

[ljwolf]

Watching these updates roll in is very exciting :)

I wanted to just make a minor suggestion: the geopandas.points_from_xy can be significantly more efficient than the list comprehension + shapely.geometry.Point() strategy used here.

spacv/spacv/utils.py

Line 20 in 13f6303

XYs = gpd.GeoDataFrame({'geometry': [Point(xy) for xy in XYs]} )

This is mainly because of efficiency gains made using pygeos, which vectorizes the creation of the points. I'd use this wherever you're casting from arrays to geopandas.Geo* containers.

[SamComber]

Thanks and great suggestion, I wasn't aware of this! I can see the performance gains are made from geopandas here conditional on pygeos being installed.

Will apply this in the next push. As ever, your feedback and review is always welcome.