Click events don't work if closeOnOverlayClick is true

[DarthSim]

Here is a bug: https://github.com/samdark/the-modal/blob/master/jquery.the-modal.js#L74 . This block of code stops bubbling of click event, so if we define hendler like $("body").on("click", ".some_class", doAwesomeActions), "awesome actions" won't be done.
Solution is cheching class of event target instead of stopping propagation. Like this:

if(localOptions.closeOnOverlayClick) {
    $('.' + localOptions.overlayClass).on('click.' + pluginNamespace, function(e){
        if (e.target.className == localOptions.overlayClass){
            $.modal().close();
        }
    });
}

[ibrahima]

This affects React apps badly as React's event handler sits on the document element instead of the actual element you put them on. Is the reason for handling this with event.stopPropagation performance?

[samdark]

Not really. You're welcome to pull request.

[ibrahima]

OK, thanks, done!

[samdark]

Merged.

[ibrahima]

Thanks!

On Wed, Jan 27, 2016 at 3:03 AM Alexander Makarov notifications@github.com
wrote:

Merged.

—
Reply to this email directly or view it on GitHub
#25 (comment).