Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set array items display incorrectly #84

Open
lbogdan opened this issue May 27, 2021 · 2 comments
Open

Set array items display incorrectly #84

lbogdan opened this issue May 27, 2021 · 2 comments

Comments

@lbogdan
Copy link

lbogdan commented May 27, 2021

Brace yourselves, issues from CodeSandbox incoming! 😃

Consider this code:

const testSet = new Set();

testSet.add(1);
testSet.add(2);
testSet.add({ foo: 'bar' });
testSet.add([3, 4]);

console.log(testSet);

Expected output (from Chrome's console):

image

Actual output:

image

(note that objects are handled fine)

Reproduction sandbox: https://codesandbox.io/s/console-feed-set-array-item-f3dmn

Related CodeSandbox issue: codesandbox/codesandbox-client#5493

@samdenty
Copy link
Owner

samdenty commented May 27, 2021

I believe this stems from the underlying react-inspector library. With all the past issues opened though from styling/virtualization, I'm tempted more towards a rewrite.

I saw that https://github.com/facebook/flipper started using it too a while back. I briefly played around with it locally and it looked amazing - not sure if they ran into perf issues & are still using it CC @mweststrate I'm curious to learn more

@samdenty
Copy link
Owner

we'd need a new transform similar to the promise one #86.

<span style={{ opacity: 0.6 }}>{`<pending>`}</span>

though the promise state can't update due to lack of virtualization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants