Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable arg queries #90

Closed
wants to merge 2 commits into from
Closed

Fix nullable arg queries #90

wants to merge 2 commits into from

Conversation

Yomanz
Copy link
Contributor

@Yomanz Yomanz commented Apr 7, 2020

This fixes an issue with marking queries with arguments as optional,

The gqless package is noted in the changeset as it was left out in another PR.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2020

🦋 Changeset is good to go

Latest commit: 2ae013c

We got this.

This PR includes changesets to release 2 packages
Name Type
gqless Patch
@gqless/schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ae013c:

Sandbox Source
jovial-chandrasekhar-dv9m9 Configuration

@Arrow7000
Copy link

Hey, I'm keen for this to go through as this apparently fixes my issue.

Is this PR waiting for something before it can be merged? I see that there are some failing tests, are they being looked at? Is there anything I could do to help?

@yovanoc
Copy link

yovanoc commented May 12, 2020

Hope this will be fixed :(

@Yomanz
Copy link
Contributor Author

Yomanz commented Sep 2, 2020

I need to remake this because it's not correct.

@Yomanz Yomanz closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants