Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix rows and columns parameters #17
Merged
Conversation
Dividing the image by specifying the number of rows and columns works again.
Allow to slice an image with only one row, or one column.
Finish adding support to the slicer binary. The only drawback is that the tile numbers must be specified with -n. But this way is consistent and more polished than asking the user to type 0 before specifying the columns and rows.
This comment has been minimized.
This comment has been minimized.
|
I didn't realize I wasn't working on another branch so I pushed my new changes. Now I also added support for the slicer binary. It's consistent, I verified it works, and I also verified that not sending the command line parameters causes an error as expected. |
This comment has been minimized.
This comment has been minimized.
|
Brilliant! Many thanks for your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dc740 commentedMay 7, 2019
The extra parameter was not being used, so I left one reference, and deleted the reference that prevented me from specifying the number of rows and columns to divide the file.
These could be handy for the command line binary too.