Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rows and columns parameters #17

Merged
merged 3 commits into from Sep 27, 2019
Merged

Fix rows and columns parameters #17

merged 3 commits into from Sep 27, 2019

Conversation

@dc740
Copy link
Contributor

dc740 commented May 7, 2019

The extra parameter was not being used, so I left one reference, and deleted the reference that prevented me from specifying the number of rows and columns to divide the file.

These could be handy for the command line binary too.

dc740 added 3 commits May 7, 2019
Dividing the image by specifying the number of rows and columns works
again.
Allow to slice an image with only one row, or one column.
Finish adding support to the slicer binary. The only drawback is that
the tile numbers must be specified with -n. But this way is consistent
and more polished than asking the user to type 0 before specifying
the columns and rows.
@dc740

This comment has been minimized.

Copy link
Contributor Author

dc740 commented May 8, 2019

I didn't realize I wasn't working on another branch so I pushed my new changes. Now I also added support for the slicer binary. It's consistent, I verified it works, and I also verified that not sending the command line parameters causes an error as expected.

@samdobson samdobson merged commit 8c4d97b into samdobson:master Sep 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samdobson

This comment has been minimized.

Copy link
Owner

samdobson commented Sep 27, 2019

Brilliant! Many thanks for your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.