This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Fix rows and columns parameters #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dividing the image by specifying the number of rows and columns works again.
Allow to slice an image with only one row, or one column.
Finish adding support to the slicer binary. The only drawback is that the tile numbers must be specified with -n. But this way is consistent and more polished than asking the user to type 0 before specifying the columns and rows.
|
I didn't realize I wasn't working on another branch so I pushed my new changes. Now I also added support for the slicer binary. It's consistent, I verified it works, and I also verified that not sending the command line parameters causes an error as expected. |
|
Brilliant! Many thanks for your work on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra parameter was not being used, so I left one reference, and deleted the reference that prevented me from specifying the number of rows and columns to divide the file.
These could be handy for the command line binary too.