Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor improvements to the code #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Some minor improvements to the code #2

wants to merge 7 commits into from

Conversation

tctovsli
Copy link

I have changed the following things (untested):

  • Moved all module imports to the top of the code
  • Corrected spelling error in one of the functions
  • Added a requirements-section in the README

sameera-madushan
sameera-madushan reviewed Apr 14, 2020
View reviewed changes
Copy link
Owner

@sameera-madushan sameera-madushan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tctovsli Implicit loading of modules is deprecated.
Capture

sameera-madushan
sameera-madushan requested changes Apr 14, 2020
View reviewed changes
Copy link
Owner

@sameera-madushan sameera-madushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the pull request. I've left a comment that should be addressed before this gets merged.

sbox.py Outdated Show resolved Hide resolved
sameera-madushan
sameera-madushan approved these changes Apr 14, 2020
View reviewed changes
Copy link
Owner

@sameera-madushan sameera-madushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting the typo...

@sameera-madushan
Copy link
Owner

Hey @tctovsli thanks for your contribution ♥
Since the commits of this PR got changed (now outdated) while merging other PRs i decided not to merge this PR but i will keep this PR open because it’s never nice to reject someone’s work. Please don't be discouraged to contribute in the future even though this PR won't get merged. Thank you for understanding.

sameera-madushan pushed a commit that referenced this pull request Apr 17, 2020
@mihakodric
Merge pull request #2 from mihakodric/mihakodric-patch-1
a3b2c7a 
Update sbox.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nish8192 Nish8192 Nish8192 approved these changes

@sameera-madushan sameera-madushan sameera-madushan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tctovsli @sameera-madushan @Nish8192