fix PG_DATADIR initialization for cases when empty or contains too many files #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation passed nothing to `chmod` when PG_DATADIR is empty - this results in `chmod` raises syntax error. We also can see `Argument list too long` error when PG_DATADIR contains too many files / directries (restriction defined by ARG_MAX) Use xargs to avoid errors above
kkimurak
force-pushed
the
hotfix-chmod-failue
branch
from
d43f983
to
ea51b26
Compare
|
Rebased onto 0c081e0 (14-20230628 release). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation passed nothing to
chmodwhenPG_DATADIRis empty. This results inchmodraises syntax error and wrong permissions will not be corrected : This is the cause of problem reported in sameersbn/docker-gitlab#2224We also can see
Argument list too longerror whenPG_DATADIRcontains too many files / directories (restriction defined by ARG_MAX) : this is reported in #148This PR make
create_datadir()to handle those situations by usingxargs.