Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete previous attachment, when editing transaction #19

Open
sameersyd opened this issue Feb 17, 2021 · 5 comments
Open

Delete previous attachment, when editing transaction #19

sameersyd opened this issue Feb 17, 2021 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@sameersyd
Copy link
Owner

sameersyd commented Feb 17, 2021

The app holds memory of previous images attached in a transaction even after deleting or updating them with new one.

  • Delete the previous images from memory so the app size can decrease
@sameersyd sameersyd added the enhancement New feature or request label Feb 17, 2021
@sameersyd sameersyd added this to the Ver: 1.0.1 milestone Feb 17, 2021
@tejuamirthi
Copy link

tejuamirthi commented Feb 27, 2021

Hey @sameersyd are you working in this? Or is it available for people to contribute? If yes, let me know. I'd like to work on this. Thanks!

@sameersyd sameersyd modified the milestones: Ver: 1.0.1, Ver: 1.0.2 Feb 27, 2021
@sameersyd
Copy link
Owner Author

Hello @tejuamirthi, Yes this project is open for contribution. I'll assign you for this issue.

@tejuamirthi
Copy link

So, @sameersyd
Are you sure about the app storing and not relieving the memory of the images deleted/updated?
If that is the case, they must be show in transactions right? As far as I can see about this and the issue I can think of is, the memory allocated for the image might be open for re-use, but not cleared. That did answer my questions. I'd love to hear your thoughts. WDYT? Sorry for getting back late, thanks!

@sameersyd
Copy link
Owner Author

@tejuamirthi When a transaction is deleted, the app deletes core-data object but the image in CD Object is still there, holding the disc memory, thus not decreasing the app size. You can either use instruments or directly look into simulator storage using path, the app will have all the images incl. deleted transaction's.

@narendrajagne
Copy link

Hii can you assign me this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants