Typing error with DataHelper.get_element_text

[cmutel]

DataHelper.get_element_text is supposed to always return a str, but calls get_element, which can return None. Pyright is not happy.

[sami-m-g]

@cmutel DataHelper.get_element_text is set to return a default value of Defaults.TYPE_DEFAULTS[str] in that case.

[cmutel]

Don't shoot me, I am just the messenger!

I don't think this is a real issue, we know a "text" element which follows the XSD will be a str, and if falsely will get a replacement with Defaults.TYPE_DEFAULTS[str]; I wonder if there is a way to get pyright to realize this. BTW, pyright is from Microsoft so somehow I am holding you a bit responsible :p

[sami-m-g]

I found the issue which was that Defaults.TYPE_DEFAULTS[str] itself was declared as Any since Defaults.TYPE_DEFAULTS holds the defaults for different data types hence the return type is Any. b679357 resolved this by wrapping Defaults.TYPE_DEFAULTS[str] with a str().