Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CAS number validity on export #30

Closed
cmutel opened this issue Feb 24, 2023 · 2 comments
Closed

Check CAS number validity on export #30

cmutel opened this issue Feb 24, 2023 · 2 comments
Milestone
v2.0.0

Comments

@cmutel
Copy link
Member

cmutel commented Feb 24, 2023

After #29 is merged, we should use it when someone sets Exchange.CASNumber and ReferenceFunction.CASNumber in v1, and casNumber in the exchange classes in v2.
@sami-m-g
Copy link
Member

@cmutel - 9aa12d3 completes this, however; it seems that the schema set the size or CASNumber to be 11. We need to either change the schema -and all sample data- to set size to 12, basically breaking it or change our validation to set size to 11.

@sami-m-g sami-m-g mentioned this issue Feb 26, 2023
Closed
@sami-m-g sami-m-g added this to the v2.0.0 milestone Feb 26, 2023
@sami-m-g
Copy link
Member

Resolved by #31 and following commits.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@cmutel @sami-m-g